Update MySQL SystemMethods.CurrentUTCDateTime to Use Expression #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forced ci build to run. Github breaking automatic ci builds is tough. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1796.
Currently, when creating a MySQL column using the SystemMethods.CurrentUTCDateTime, a MySQL syntax error is thrown, as UTC_TIMESTAMP is not a literal constant.
Unit tests were added, but integration tests were not. I could not find any integration tests for SystemMethods defaults, though I can add some for the DBMS I am familiar with, if desired. (MySQL, SQL Server, and possibly PostgreSQL, but I am not familiar enough with Hana, DB2, etc. to get those integration tests working.)
Adjustments made based on MySQL documentation: https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html#data-types-defaults-explicit
I am relatively certain this is not a breaking change, as based on the documentation, it does not look like UTC_TIMESTAMP would have worked in any MySQL version prior to 8.0.13.