[web] Set the correct href on semantic links #52720
Draft
+118
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
May 13, 2024
| // https://github.com/flutter/flutter/issues/102535. | ||
| element.setAttribute('href', '#'); | ||
| // TODO: The <a> element has `aria-label={value}`. We should stop that! | ||
| element.setAttribute('href', semanticsObject.hasValue ? semanticsObject.value! : '#'); |
There was a problem hiding this comment.
If this is going to use value as href, then this role manager should not use the withBasics super constructor, because that one adds the LabelAndValue role which includes value in the label. Alternatively, we can make LabelAndValue configurable so it does not include value in some cases.
There was a problem hiding this comment.
Fixed it by introducing an allowlist labelSources (also used it for incrementable, which was hardcoded as a one-off case).
8 tasks
mdebbar
force-pushed
the
link_semantics_href
branch
from
ba94ab7
to
2b7967a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueas thehrefattribute for links.hrefattribute whenvalueis empty (prevents unwanted navigation).value.Part of flutter/flutter#102535
Fixes flutter/flutter#146291