Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate _LerpSides classes with WigetStateProperty<BorderSide?> type into a new WidgetStateBorderSide.lerp #148057

Open
TahaTesser opened this issue May 9, 2024 · 0 comments · May be fixed by #148122
Assignees
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team

Comments

@TahaTesser
Copy link
Member

TahaTesser commented May 9, 2024

Use case

Currently, there are 3 classes using same local _LerpSides class to resolve WigetStateProperty<BorderSide?> type.

image

Proposal

Introduce WidgetStateBorderSide.lerp which can be resolve WigetStateProperty<BorderSide?> properties and remove duplicate implementations.

@TahaTesser TahaTesser added in triage Presently being triaged by the triage team c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 9, 2024
@TahaTesser TahaTesser self-assigned this May 9, 2024
@TahaTesser TahaTesser linked a pull request May 10, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team
Projects
Status: PR submitted
Development

Successfully merging a pull request may close this issue.

1 participant