Introduce WidgetStateBorderSide.lerp
#148122
Open
+82
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
TahaTesser
force-pushed
the
WidgetStateBorderSide_lerp
branch
from
bb9b8d5
to
9c60054
Compare
TahaTesser
changed the title
WidgetStateBorderSide.lerp
| return BorderSide.lerp(resolvedA, BorderSide(width: 0, color: resolvedA.color.withAlpha(0)), t); | ||
| } | ||
| return BorderSide.lerp(resolvedA, resolvedB, t); | ||
| return MaterialStateBorderSide.lerp(a, b, t); |
There was a problem hiding this comment.
Since MaterialStateBorderSide is a typedef now, should we not be using WidgetStateBorderSide directly here?
There was a problem hiding this comment.
MaterialStateBorderSide and MaterialState are still widely used in the material library, not deprecated for the source code so I'm keeping this consistency.
When MaterialState is deprecated period is over then this would be replaced in the material library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Consolidate
_LerpSidesclasses withWigetStateProperty<BorderSide?>type into a newWidgetStateBorderSide.lerpPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.