Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router_builder] add onExit parameter #137394

Open
2 tasks done
benjaminledet opened this issue Oct 27, 2023 · 5 comments · May be fixed by flutter/packages#6614
Open
2 tasks done

[go_router_builder] add onExit parameter #137394

benjaminledet opened this issue Oct 27, 2023 · 5 comments · May be fixed by flutter/packages#6614
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: go_router_builder The go_router_builder package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-go_router Owned by Go Router team

Comments

@benjaminledet
Copy link

benjaminledet commented Oct 27, 2023 •
edited

Is there an existing issue for this?

Use case

The parameter onExit was recently added to goRouter. I would like to use it with the goRouter builder but it is not possible at the moment.

Proposal

Add onExit as an optional parameter on the go_router_builder api.
@darshankawar darshankawar added in triage Presently being triaged by the triage team c: new feature Nothing broken; request for a new capability package flutter/packages repository. See also p: labels. c: proposal A detailed proposal for a change to Flutter p: go_router_builder The go_router_builder package team-go_router Owned by Go Router team and removed in triage Presently being triaged by the triage team labels Oct 27, 2023
@chunhtai chunhtai added P1 High-priority issues at the top of the work list triaged-go_router Triaged by Go Router team labels Nov 2, 2023
@ManuelRauber ManuelRauber mentioned this issue Dec 11, 2023
Open
@rorystephenson
Copy link

rorystephenson commented Feb 27, 2024 •
edited

@chunhtai would you have any pointers for opening a PR for this, maybe there is a similar feature that could serve as a starting point? cc @johnpryan

@flutter-triage-bot
Copy link

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot flutter-triage-bot bot removed the triaged-go_router Triaged by Go Router team label Mar 8, 2024
@ValentinVignal ValentinVignal mentioned this issue Apr 10, 2024
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Apr 24, 2024
@ValentinVignal
[go_router] Add GoRouterState state parameter to `GoRouterData.onEx…
26f660b 
…it` (#6495)

Part of flutter/flutter#137394

I need to add the `state` parameter to the `onExit` method so I can use the `factoryImpl(state)`:

https://github.com/flutter/packages/blob/d4cd4f00254b2fdb50767c837ecd27bcbac488cd/packages/go_router/lib/src/route_data.dart#L100-L118
@ValentinVignal ValentinVignal linked a pull request Apr 26, 2024 that will close this issue
Open
11 tasks
@ValentinVignal
Copy link
Contributor

@benjaminledet You should be able to use onExit with go_router: ^14.0.0

@rorystephenson
Copy link

@ValentinVignal this issue is for go_router_builder, based on the changelog it doesn't look like onExit is available in go_router_builder yet.

@ValentinVignal
Copy link
Contributor

ValentinVignal commented Apr 29, 2024 •
edited

@rorystephenson GoRouteData which is the class you need to extend comes from go_router not go_router_builder.

It is then used by go_router_builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: go_router_builder The go_router_builder package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-go_router Owned by Go Router team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[go_router_builder] Add test for onExit ValentinVignal/flutter__packages
5 participants
@rorystephenson @benjaminledet @ValentinVignal @chunhtai @darshankawar