[go_router_builder] Add test for onExit
#6614
Open
+206
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
The tests are failing because of #6623 |
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2024
…o the `onExit` (#6623) While working on #6614, I notice some issues with the state that is given to the `onExit` (see the run https://github.com/flutter/packages/pull/6614/checks?check_run_id=24284539541) This PR uses the correct configuration to build the state and pass it to the `onExit`
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
ValentinVignal
force-pushed
the
go-router-builder/Add-tests-for-on-exit
branch
from
39d7939
to
0f8be0e
Compare
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #6495
Fixes flutter/flutter#137394
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.