[camera] MediaSettings parameter for createCameraWithSettings #3586
+106
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROGrand
requested review from
cbracken,
hellohuanlin,
camsim99,
ditman and
bparrishMines
as code owners
github-actions
bot
added
p: camera
platform-android
platform-ios
platform-web
platform-windows
labels
|
This is main PR. Platform interface's PR is here: #3615 |
packages/camera/camera/example/integration_test/camera_test.dart
Outdated
Show resolved
Hide resolved
MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).
stuartmorgan
requested changes
Apr 17, 2024
packages/camera/camera/README.md
Outdated
| @@ -100,6 +100,7 @@ Here is a small example flutter app displaying a full screen camera preview. | |||
| <?code-excerpt "readme_full_example.dart (FullAppExample)"?> | |||
| ```dart | |||
| import 'package:camera/camera.dart'; | |||
| import 'package:camera_platform_interface/camera_platform_interface.dart'; | |||
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| // #docregion FullAppExample | |||
| import 'package:camera/camera.dart'; | |||
| import 'package:camera_platform_interface/camera_platform_interface.dart'; | |||
Comment on lines
237
to
244
| CameraController( | ||
| CameraDescription description, | ||
| this.resolutionPreset, { | ||
| this.enableAudio = true, | ||
| ResolutionPreset resolutionPreset, { | ||
| bool enableAudio = true, | ||
| this.imageFormatGroup, | ||
| }) : mediaSettings = MediaSettings( | ||
| resolutionPreset: resolutionPreset, enableAudio: enableAudio), | ||
| super(CameraValue.uninitialized(description)); |
There was a problem hiding this comment.
This hasn't been addressed.
|
Sorry, what did you mean? |
|
|
@stuartmorgan |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 6, 2024
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
May 6, 2024
…r#3586) This PR is for enabling fps and bitrate control of recorded video. Allow users to more control over recorded video size. `CameraPlatform.createCameraWithSettings` is added, leaving original `CameraPlatform.createCamera` commented as deprecated. So this is not breaking change. Tested on a set of mobile devices. Web support depends on browser (perfect with Firefox). Fixes flutter/flutter#54339
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 6, 2024
flutter/packages@f4719ca...2dfe645 2024-05-06 PROGrand@users.noreply.github.com [camera] MediaSettings parameter for createCameraWithSettings (flutter/packages#3586) 2024-05-06 tarrinneal@gmail.com Fix unnecessary toList/fromList calls during encode/decode process (flutter/packages#6426) 2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter from bf7191f to f1037a0 (21 revisions) (flutter/packages#6641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for enabling fps and bitrate control of recorded video.
Allow users to more control over recorded video size.
CameraPlatform.createCameraWithSettingsis added, leaving originalCameraPlatform.createCameracommented as deprecated. So this is not breaking change.Tested on a set of mobile devices.
Web support depends on browser (perfect with Firefox).
Fixes flutter/flutter#54339