[google_maps_flutter] Marker clustering support #4319

jokerttu · 2023-06-27T07:03:36Z

Adds the initial support for the marker clustering for Android, iOS and Web platforms.
Clustering is implemented using native google maps utils libraries for Android, iOS and Web.

The Google Maps Utils libraries provides the capability for future additions of features available under these libraries to the google_maps_flutter plugin, such as heatmaps, although they are not included in this PR.

This PR is created from previous PR: flutter/plugins#6752

Resolves flutter/flutter#26863

Android:

iOS:

Web:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie · 2023-08-22T22:52:35Z

@jokerttu Is this still something you are interested in working on? How can we help you?

thedalelakes · 2023-10-05T15:41:28Z

@jokerttu is this still something you're working on?

jokerttu · 2023-10-13T13:39:36Z

@jokerttu is this still something you're working on?

Yes, I am scheduled to work on this issue next week and will update the PR accordingly in the near future. The recent architectural changes in the google_maps_flutter_web implementation have affected the integration tests, which I am addressing. Additionally, some new methods introduced in this PR will likely require updates to the native unit tests.

wangela · 2023-10-30T15:57:25Z

@stuartmorgan this is ready for review. We inspected the logs for the failing web platform tests and it seems to be reporting based on Android?

jokerttu · 2023-10-31T08:28:34Z

Note: that the original PR was reviewed at plugins repository at flutter/plugins#6752
Implementation parts have been mainly same, but small fixes and changes has been done to fix conflicts.
Web tests are rewritten because of changes on the web implementation (web plugin was endorsed).
iOS Google Maps Utils library version is now pinned to 4.1.0 as newer versions do not support iOS platform versions 11 and 12

stuartmorgan · 2023-11-17T12:19:22Z

@stuartmorgan this is ready for review. We inspected the logs for the failing web platform tests and it seems to be reporting based on Android?

This is because there is a weird circular dependency in the tests where google_maps_flutter_web's example depends on google_maps, which then is depending on a non-overridden version of google_maps_flutter_android so things no longer match. Adding a dependency override for _android in google_maps_flutter_web/example/pubspec.yaml should allow the tests to run.

stuartmorgan

Thanks for your patience on this; I've finished reviewing the platform interface, and since the overall structure was already reviewed in the previous PR you are good to split that out into the first prequel PR. I've left some comments that you can either address here before splitting, or just address in the new PR.

I should have the rest of the re-review done later today but I wanted to get this part out first so you could work on that in parallel.

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart

packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart

...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart

packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart

...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart

stuartmorgan · 2023-11-17T13:12:20Z

@ditman Looks like the original never got your review for web; if you could take a look here when you get a chance that would be great.

packages/google_maps_flutter/google_maps_flutter_web/README.md

packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/utils/cluster_manager.dart

stuartmorgan · 2023-11-17T16:35:10Z

packages/google_maps_flutter/google_maps_flutter_web/example/web/index.html

@@ -7,6 +7,7 @@
        <title>Browser Tests</title>
        <!-- This API key comes from: go/flutter-maps-web-tests-api-key (GCP project: flutter-infra) -->
        <script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAa9cRBkhuxGq3Xw3HPz8SPwaVOhRmm7kk&libraries=geometry"></script>
+        <script src="https://unpkg.com/@googlemaps/markerclusterer@2.5.0/dist/index.min.js"></script>


(If there's any change based on my comment on the app-facing package, we should make sure to make it here as well.)

packages/google_maps_flutter/google_maps_flutter_web/lib/src/marker_clustering.dart

apackin · 2024-01-16T18:00:35Z

Any progress updates on when we can expect this to come out?

hellohuanlin · 2024-01-17T21:55:47Z

@jokerttu is this ready for another review?

jokerttu · 2024-01-18T18:01:21Z

@hellohuanlin

@jokerttu is this ready for another review?

Not yet, most of the issues @stuartmorgan pointed out are fixed, but there are still few that are not yet done.
Also, before this can be finalized, we need also some resolution to this question waiting review from @ditman: (#4319 (comment))

jokerttu · 2024-02-19T08:43:10Z

@stuartmorgan

It looks like this still hasn't been split out?

The review comments were resolved in this PR before splitting so that the platform-specific implementations would not stretch too far in time after the platform interface update.

Here is the first prequel PR for google_maps_flutter_platform_interface: #6158

stuartmorgan · 2024-02-20T19:41:49Z

However, a few discussions remain open, and I'm actively seeking further input on those.

Was there anything other than web-specific questions? I looked back through the comments and didn't find any unresolved discussions with questions other than the web ones, but I may have missed something.

jokerttu · 2024-02-21T13:30:55Z

@stuartmorgan

However, a few discussions remain open, and I'm actively seeking further input on those.

Was there anything other than web-specific questions? I looked back through the comments and didn't find any unresolved discussions with questions other than the web ones, but I may have missed something.

Yes, checked and only web-specific discussions are still open.

jokerttu · 2024-02-23T14:40:32Z

@stuartmorgan added prequel PR:s for platforms as well as draft, as the platform_interface (#6158) PR has not yet landed:
Android: #6185
iOS: #6186
Web: #6187 (@ditman)

…terface (#6158) This PR introduces support for marker clustering This is prequel PR for: #4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

flutter-dashboard · 2024-03-01T13:42:31Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jokerttu · 2024-03-01T13:45:43Z

Converted to draft to avoid unnecessary reviews before the platform implementations are landed.

…terface (flutter#6158) This PR introduces support for marker clustering This is prequel PR for: flutter#4319 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#26863

ParkBud · 2024-04-04T22:48:29Z

@jokerttu any updates on this 🥺 Really looking forward to it. Really appreciate you for taking this on!

jokerttu · 2024-04-05T10:13:49Z

@jokerttu any updates on this 🥺 Really looking forward to it. Really appreciate you for taking this on!

The work is ongoing on platform implementation PR:s
~~#6185~~ (merged)
#6186
~~#6187~~ (merged)

This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

…6185) This PR introduces support for marker clustering for Android platform An example usage is available in the example application at `./packages/google_maps_flutter/google_maps_flutter_android/example` on the page `Manage clustering` This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_android` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

This PR introduces support for marker clustering for Web platform This is prequel PR for: flutter#4319 and sequel PR for: flutter#6158 Containing only changes to `google_maps_flutter_web` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863 --------- Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>

stuartmorgan · 2024-06-04T19:48:02Z

Status update from triage: Blocked on landing the iOS platform implementation, which is turn blocked on Google Maps SDK-level issues.

github-actions bot added p: google_maps_flutter platform-android platform-ios platform-web labels Jun 27, 2023

jokerttu force-pushed the google_maps_flutter_cluster_support branch 2 times, most recently from b805eab to 499b82b Compare June 30, 2023 13:26

Zazo032 mentioned this pull request Jul 25, 2023

[google_maps_flutter] Support marker clustering flutter/flutter#26863

Open

jokerttu force-pushed the google_maps_flutter_cluster_support branch 5 times, most recently from b44d05a to e052a4c Compare October 26, 2023 12:33

jokerttu marked this pull request as ready for review October 27, 2023 14:52

jokerttu requested review from cyanglaz, reidbaker, ditman and stuartmorgan as code owners October 27, 2023 14:52

stuartmorgan reviewed Nov 17, 2023

View reviewed changes

stuartmorgan requested changes Nov 17, 2023

View reviewed changes

jokerttu requested a review from hellohuanlin as a code owner December 20, 2023 09:31

jokerttu mentioned this pull request Feb 19, 2024

[google_maps_flutter] Add support for marker clustering - platform interface #6158

Merged

11 tasks

This was referenced Feb 23, 2024

[google_maps_flutter] Add marker clustering support - android implementation #6185

Merged

[google_maps_flutter] Add marker clustering support - iOS implementation #6186

Open

[google_maps_flutter] Add marker clustering support - web implementation #6187

Merged

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 5083248 to 0dcab77 Compare March 1, 2024 11:43

github-actions bot removed platform-android platform-ios labels Mar 1, 2024

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 0dcab77 to d012215 Compare March 1, 2024 12:10

jokerttu marked this pull request as draft March 1, 2024 13:44

jokerttu force-pushed the google_maps_flutter_cluster_support branch from d012215 to 0bd74d3 Compare March 7, 2024 13:09

cyanglaz removed their request for review March 19, 2024 21:42

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 0bd74d3 to 04070f9 Compare April 3, 2024 12:13

[google_maps_flutter] Add clustering support

850bf1e

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 04070f9 to 850bf1e Compare April 30, 2024 12:41

stuartmorgan added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Marker clustering support #4319

[google_maps_flutter] Marker clustering support #4319

jokerttu commented Jun 27, 2023 •

edited

Hixie commented Aug 22, 2023

thedalelakes commented Oct 5, 2023

jokerttu commented Oct 13, 2023

wangela commented Oct 30, 2023

jokerttu commented Oct 31, 2023 •

edited

stuartmorgan commented Nov 17, 2023

stuartmorgan left a comment

stuartmorgan commented Nov 17, 2023

stuartmorgan Nov 17, 2023

apackin commented Jan 16, 2024

hellohuanlin commented Jan 17, 2024

jokerttu commented Jan 18, 2024 •

edited

jokerttu commented Feb 19, 2024

stuartmorgan commented Feb 20, 2024

jokerttu commented Feb 21, 2024 •

edited

jokerttu commented Feb 23, 2024

flutter-dashboard bot commented Mar 1, 2024

jokerttu commented Mar 1, 2024

ParkBud commented Apr 4, 2024

jokerttu commented Apr 5, 2024 •

edited

stuartmorgan commented Jun 4, 2024

[google_maps_flutter] Marker clustering support #4319

Are you sure you want to change the base?

[google_maps_flutter] Marker clustering support #4319

Conversation

jokerttu commented Jun 27, 2023 • edited

Pre-launch Checklist

Hixie commented Aug 22, 2023

thedalelakes commented Oct 5, 2023

jokerttu commented Oct 13, 2023

wangela commented Oct 30, 2023

jokerttu commented Oct 31, 2023 • edited

stuartmorgan commented Nov 17, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan commented Nov 17, 2023

stuartmorgan Nov 17, 2023

Choose a reason for hiding this comment

apackin commented Jan 16, 2024

hellohuanlin commented Jan 17, 2024

jokerttu commented Jan 18, 2024 • edited

jokerttu commented Feb 19, 2024

stuartmorgan commented Feb 20, 2024

jokerttu commented Feb 21, 2024 • edited

jokerttu commented Feb 23, 2024

flutter-dashboard bot commented Mar 1, 2024

jokerttu commented Mar 1, 2024

ParkBud commented Apr 4, 2024

jokerttu commented Apr 5, 2024 • edited

stuartmorgan commented Jun 4, 2024

jokerttu commented Jun 27, 2023 •

edited

jokerttu commented Oct 31, 2023 •

edited

jokerttu commented Jan 18, 2024 •

edited

jokerttu commented Feb 21, 2024 •

edited

jokerttu commented Apr 5, 2024 •

edited