Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Bump Gradle version to 7.6.3 #5522

Merged
merged 75 commits into from
Dec 13, 2023
Merged

[Android] Bump Gradle version to 7.6.3 #5522

merged 75 commits into from
Dec 13, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Nov 30, 2023 •
edited

Part of fix for flutter/flutter#138336 by bumping the Gradle version of all package example apps (plus image_picker_android plugin) to 7.6.3 from those that had a version below that to fix security vulnerability.

Also fixes a bug I found while using the update-dependencies packages tool command that caused it to not catch all of the gradle-wrapper.properties files when running with the gradle dependency + added a test for the fix.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
@camsim99
Merge remote-tracking branch 'upstream/main' into camx_occ
dec3d69
@camsim99
Merge remote-tracking branch 'upstream/main'
0e0333b
@camsim99
Merge remote-tracking branch 'upstream/main'
bd7ac99
@camsim99
Merge remote-tracking branch 'upstream/main'
5c3363b
@camsim99
Undo changes
fed9621
@camsim99
Merge remote-tracking branch 'upstream/main'
5aabe34
@camsim99
Merge remote-tracking branch 'upstream/main'
2b9a352
@camsim99
Merge remote-tracking branch 'upstream/main'
a1173da
@camsim99
Merge remote-tracking branch 'upstream/main'
cbc3d6b
@camsim99
Merge remote-tracking branch 'upstream/main'
cae5a4c
@camsim99
Merge remote-tracking branch 'upstream/main'
72283db
@camsim99
Merge remote-tracking branch 'upstream/main'
166a77c
@camsim99
Merge remote-tracking branch 'upstream/main'
399780e
@camsim99
Merge remote-tracking branch 'upstream/main'
8d5d0e7
@camsim99
Merge remote-tracking branch 'upstream/main'
084d960
@camsim99
Merge remote-tracking branch 'upstream/main'
d2a59ac
@camsim99
Merge remote-tracking branch 'upstream/main'
a1422bf
@camsim99
Merge remote-tracking branch 'upstream/main'
bdd87a6
@camsim99
Merge remote-tracking branch 'upstream/main'
137a28b
@camsim99
Merge remote-tracking branch 'upstream/main'
bc0db5a
@camsim99
Merge remote-tracking branch 'upstream/main'
d04b466
@camsim99
Merge remote-tracking branch 'upstream/main'
a9cfe87
@camsim99
Merge remote-tracking branch 'upstream/main'
a32def1
@camsim99
Merge remote-tracking branch 'upstream/main'
4785148
@camsim99
Merge remote-tracking branch 'upstream/main'
7a8fc69
@camsim99
Merge remote-tracking branch 'upstream/main'
b02e15f
@camsim99
Merge remote-tracking branch 'upstream/main'
c6e5868
@camsim99
Merge remote-tracking branch 'upstream/main'
0c0065a
@camsim99
Merge remote-tracking branch 'upstream/main'
9dfe259
@camsim99
Merge remote-tracking branch 'upstream/main'
bfcc0df
stuartmorgan
stuartmorgan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changelogs removed

packages/animations/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## NEXT

* Updates example app Gradle version to 7.6.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is uninteresting to clients; we can revert all these CHANGELOGs.

packages/image_picker/image_picker_android/CHANGELOG.md
@@ -1,3 +1,7 @@
## 0.8.9+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except this one :)

@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Dec 13, 2023
@stuartmorgan
Copy link
Contributor

changelog override: Minor example app configuration changes that wouldn't need to be copied by clients aren't necessary to highlight.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023
tarrinneal
tarrinneal approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

number get bigger!

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 13, 2023

auto label is removed for flutter/packages/5522, due to - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

Piinks
Piinks approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chunhtai
chunhtai approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023
@auto-submit auto-submit bot merged commit 2b53f72 into flutter:main Dec 13, 2023
80 checks passed
foxtrotravi pushed a commit to foxtrotravi/packages that referenced this pull request Dec 14, 2023
@camsim99 @foxtrotravi
[Android] Bump Gradle version to 7.6.3 (flutter#5522)
c5a739e 
Part of fix for flutter/flutter#138336 by bumping the Gradle version of all package example apps (plus `image_picker_android` plugin) to 7.6.3 from those that had a version below that to fix security vulnerability.

Also fixes a bug I found while using the `update-dependencies` packages tool command that caused it to not catch all of the `gradle-wrapper.properties` files when running with the `gradle` dependency + added a test for the fix.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2023
@engine-flutter-autoroll
2b53f72 [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522)
10200cf
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 14, 2023
@engine-flutter-autoroll
Roll Packages from b5958e2 to 1151191 (10 revisions) (#140154)
3a20f9c 
flutter/packages@b5958e2...1151191

2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674)
2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669)
2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567)
2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634)
2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628)
2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660)
2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522)
2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521)
2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478)
2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@camsim99 camsim99 mentioned this pull request Dec 15, 2023
Closed
2 tasks
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@engine-flutter-autoroll @Michal-MK
Roll Packages from b5958e2 to 1151191 (10 revisions) (flutter#140154)
9697126 
flutter/packages@b5958e2...1151191

2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674)
2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669)
2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567)
2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634)
2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628)
2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660)
2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522)
2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521)
2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478)
2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@engine-flutter-autoroll @Markzipan
Roll Packages from b5958e2 to 1151191 (10 revisions) (flutter#140154)
0823a65 
flutter/packages@b5958e2...1151191

2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674)
2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669)
2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567)
2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634)
2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628)
2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660)
2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522)
2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521)
2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478)
2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@reidbaker reidbaker reidbaker approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@gmackall gmackall gmackall approved these changes

@chunhtai chunhtai chunhtai approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer goderbauer is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: animations p: camera p: dynamic_layouts The dynamic_layouts package p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_markdown p: flutter_plugin_android_lifecycle p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: palette_generator p: path_provider p: pigeon p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
8 participants
@camsim99 @stuartmorgan @reidbaker @gspencergoog @Piinks @gmackall @chunhtai @tarrinneal