[video_player] Added onScrubbingCallback to VideoProgressIndicator
#6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
requested changes
Mar 9, 2024
| @@ -31,6 +31,9 @@ VideoPlayerPlatform get _videoPlayerPlatform { | |||
| return currentInstance; | |||
| } | |||
|
|
|||
| /// Signature of a callback that returns the current duration after scrubbing through the [VideoProgressIndicator]. | |||
| typedef OnScrubbingCallback = void Function(Duration)?; | |||
There was a problem hiding this comment.
if you're already making this optional on the classes it's used in, is it still necessary to do it here as well?
|
@stuartmorgan for second review |
|
Please see my comments in the issue about better understanding the use case. If this actually needs to be done at the level of the UI element, I'm not sure this is a sufficiently common use case to warrant being added to the package (vs. the application in question just implementing a custom seek bar). |
|
Marking as a draft pending resolution of the high-level goal/design discussion in the issue. |
|
Closing since the issue was auto-closed due to lack of update. If you decide to revisit this in the future, please feel free to file a new issue for discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds
onScrubbingCallbacktoVideoProgressIndicatorwidget, as a nullable callback function.Related issue: flutter/flutter#144777
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).