[two_dimensional_scrollables] TreeView #6592
Open
+5,810
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
the
p: two_dimensional_scrollables
Piinks
commented
Apr 22, 2024
Piinks
commented
Apr 23, 2024
Piinks
requested review from
bleroux,
goderbauer,
HansMuller,
QuncCccccc and
TahaTesser
TahaTesser
reviewed
Apr 25, 2024
packages/two_dimensional_scrollables/lib/src/tree_view/tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/simple_tree.dart
Show resolved
Hide resolved
TahaTesser
requested changes
Apr 25, 2024
packages/two_dimensional_scrollables/example/lib/table_view/simple_table.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/simple_tree.dart
Show resolved
Hide resolved
TahaTesser
previously requested changes
Apr 25, 2024
packages/two_dimensional_scrollables/example/test/tree_view/custom_tree_test.dart
Outdated
Show resolved
Hide resolved
bleroux
reviewed
Apr 25, 2024
packages/two_dimensional_scrollables/example/lib/table_view/infinite_table.dart
Outdated
Show resolved
Hide resolved
goderbauer
reviewed
May 7, 2024
packages/two_dimensional_scrollables/example/lib/table_view/infinite_table.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/simple_tree.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/tree_delegate.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/tree_delegate.dart
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart
Outdated
Show resolved
Hide resolved
|
No rush on the re-review, it's a big one. Best taken in breaks. :) Review feedback diff is contained in 5a0194c |
goderbauer
reviewed
May 10, 2024
packages/two_dimensional_scrollables/lib/src/tree_view/tree.dart
Outdated
Show resolved
Hide resolved
| final T _content; | ||
|
|
||
| /// Other [TreeViewNode]s this this node will be [parent] to. | ||
| List<TreeViewNode<T>> get children => _children; |
There was a problem hiding this comment.
Is this true? didUpdateWidget wouldn't be called if I pass a TreeViewNode to TreeView and then later on call .children.append(...) on that TreeViewNode? Or can you show in a test that that actually works?
packages/two_dimensional_scrollables/lib/src/tree_view/tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/tree_core.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/lib/src/tree_view/render_tree.dart
Outdated
Show resolved
Hide resolved
packages/two_dimensional_scrollables/example/lib/tree_view/custom_tree.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI for Reviewers: Much of the API surface matches that of the 1D SliverTree in flutter/flutter#147171 If it changes here, it should change there, and vice versa.
📜 Design Document
Adds classes and associated callbacks and controllers for TreeView. Core components:
Along with Span subclasses for trees:
Fixes flutter/flutter#42332
Fixes flutter/flutter#126298
treeView_0.mov
treeView_1.mov
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.