Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Web - Side Nav Example Using ShellRoute #6603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alifarhanaf
Copy link

Deatiled Example of Web Side Nav with ShellRoute

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alifarhanaf
Copy link
Author

alifarhanaf commented Apr 24, 2024

@alifarhanaf alifarhanaf changed the title Web Side Nav Example Using ShellRoute Flutter Web - Side Nav Example Using ShellRoute Apr 24, 2024
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to make sure the page works correctly? Also, looks like ci is not happy.

@chunhtai
Copy link
Contributor

chunhtai commented May 9, 2024

Hi @alifarhanaf are you still working on this pr?

@alifarhanaf
Copy link
Author

@chunhtai i have added tests for above example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants