[local_auth_darwin] fixes disabled biometrics showing up as unavailable rather than disabled #6686
+1,669
−644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
Adds Swift Package Manager support to `ios_platform_images`. This does not migrate the example app's Xcode project; the example app's Xcode project is migrated whenever you run it using the Flutter tool with the Swift Package Manager feature enabled. Fixes flutter/flutter#146909
…lutter#6675) Makes `video_player_avfoundation` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146921. Redo of flutter#6634.
…picker_ios (flutter#6617) Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146919.
…to image_picker_ios (flutter#6617)" (flutter#6693) Reverts: flutter#6617 Initiated by: vashworth Reason for reverting: Failing [Mac_arm64 ios_platform_tests_shard_1 master](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_1%20master/1942/overview) Original PR Author: vashworth Reviewed By: {loic-sharma, stuartmorgan} This change reverts the following previous change: Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146919.
…clude directory is downloaded (flutter#6694) Fixes flutter/flutter#148003. Temporary solution to make tree green.
…utter#6699) Dart unit tests started failing for `pointer_interceptor` due to the `implements` tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid. ``` Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`. 00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E] Error: Please resolve the plugin pubspec errors package:flutter_tools/src/base/common.dart 10:3 throwToolExit package:flutter_tools/src/flutter_plugins.dart 1214:5 resolvePlatformImplementation package:flutter_tools/src/flutter_plugins.dart 1418:55 generateMainDartWithPluginRegistrant ===== asynchronous gap =========================== package:flutter_tools/src/test/test_compiler.dart 163:9 TestCompiler._onCompilationRequest TimeoutException after 0:12:00.000000: Test timed out after 12 minutes. package:test_api/src/backend/invoker.dart 338:28 Invoker._handleError.<fn> dart:async/zone.dart 1391:47 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 336:10 Invoker._handleError package:test_api/src/backend/invoker.dart 291:9 Invoker.heartbeat.<fn>.<fn> dart:async/zone.dart 1399:13 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 290:38 Invoker.heartbeat.<fn> dart:async-patch/timer_patch.dart 18:15 Timer._createTimer.<fn> dart:isolate-patch/timer_impl.dart 398:19 _Timer._runTimers dart:isolate-patch/timer_impl.dart 429:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 184:12 _RawReceivePort._handleMessage To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test ``` This removes the tag and does a manual roll.
To be submitted after dart-lang/lints#184 is published.
…6696) Relands flutter#6617. Was reverted in hopes of fixing flutter/flutter#148003, but ended up being fixed by flutter#6694.
Possible solution for: flutter/flutter#114559 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. --------- Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Victor Ohashi <victor.ohashi@govoll.com>
stuartmorgan
approved these changes
May 10, 2024
| @@ -1,3 +1,7 @@ | |||
| ## 1.2.3 | |||
|
|
|||
| * Fixes an issue biometrics are shown as unavailable rather than disabled when turned off in settings | |||
There was a problem hiding this comment.
Typo: "an issue where biometrics"
| @@ -1,3 +1,7 @@ | |||
| ## 1.2.3 | |||
|
|
|||
| * Fixes an issue biometrics are shown as unavailable rather than disabled when turned off in settings | |||
There was a problem hiding this comment.
This is missing a period.
…#6706) flutter/flutter@00f4066...2bfb1b0 2024-05-09 goderbauer@google.com Bump flutter_lints to 4.0 (flutter/flutter#148020) 2024-05-09 104349824+huycozy@users.noreply.github.com Add Badge example (flutter/flutter#148053) 2024-05-09 farquhar.benji@gmail.com Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true (#147097) (flutter/flutter#147098) 2024-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c2e874fdc164 to c0fd3386d018 (1 revision) (flutter/flutter#148040) 2024-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fe08238f5a52 to c2e874fdc164 (1 revision) (flutter/flutter#148038) 2024-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f2d9610a18 to fe08238f5a52 (1 revision) (flutter/flutter#148034) 2024-05-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#148011) 2024-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from bd58d2b2d655 to 69f2d9610a18 (7 revisions) (flutter/flutter#148030) 2024-05-09 kevmoo@users.noreply.github.com [web] Update wasm CLI details to be clear JavaScript is ALSO compiled (flutter/flutter#147944) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#6708) Adds Swift Package Manager support to `local_auth_darwin`. This does not migrate the example app's Xcode project to use Swift Package Manager, that's tracked by flutter/flutter#148021. Fixes flutter/flutter#146911
…r` to support Google surfaces (flutter#6638) Fixes flutter/flutter#147519
The following directories were created when I added SPM support to the `ios_platform_images` plugin: ``` packages/ios_platform_images/ios/ios_platform_images/.build/ packages/ios_platform_images/ios/ios_platform_images/.swiftpm/ ``` These shouldn't be checked-in to the packages repository. Part of flutter/flutter#148018
…ra_android (flutter#6697) Makes changes needed to land flutter#6629. Specifically: - Fixes timing issue with `stopVideoRecording` such that the `Future` it returns will only complete when CameraX reports that the recording is finalized (via listening for the [finalized video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Finalize)) - Modifies `startVideoCapturing` such that the `Future` it returns will only complete when CameraX reports that video capturing has started (via listening for the [started video recording event](https://developer.android.com/reference/androidx/camera/video/VideoRecordEvent.Start)) - Adds empty implementation and TODO for implementing `setDescriptionWhileRecording`
… Android 34 (flutter#6499) Changes webview_flutter , webview_flutter_android tests to run on emulators running SDK 34 for Android. I also 1. Changed all `unawaited` calls in non-legacy tests to `await`. I believe several of the setup steps need to be completed before running checks based on testing, so this should leave the tests safer overall. 2. Changing the integration test directory structures look like what is described in [the integration_test packages instructions](https://github.com/flutter/flutter/blob/master/packages/integration_test/README.md#package-structure). Without changing the package to this structure, CI seemed to run the tests in parallel. I am still trying to figure out why this is but no longer want to block this PR. Also removes shards for testing packages against Android 33 since no packages are running on emulators running Android 33 anymore. Fixes flutter/flutter#140001. Fixes flutter/flutter#137083.
Adds SPM support for both iOS and macOS. Also opportunistically updates the unit tests for macOS to match the changes made in flutter#4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future. Fixes flutter/flutter#146916
Adds SPM support. Does not include any package changes, to maintain compatibility with `stable`. Also adds a missing `import` in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it. Fixes flutter/flutter#146915
…r#6713) flutter/flutter@2bfb1b0...2aa05c1 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (flutter/flutter#148163) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (flutter/flutter#148156) 2024-05-11 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold.1.dart (flutter/flutter#147966) 2024-05-10 tessertaha@gmail.com Fix `MaterialStateBorderSide` lerp in the `Checkbox` and chips (flutter/flutter#148124) 2024-05-10 jmccandless@google.com Docs on TextField disposed by a scrollable (flutter/flutter#148149) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (flutter/flutter#148147) 2024-05-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#148148) 2024-05-10 32538273+ValentinVignal@users.noreply.github.com Add `clipBehavior` to `DialogTheme` (flutter/flutter#147635) 2024-05-10 31859944+LongCatIsLooong@users.noreply.github.com bump cupertino_icons to 1.08 (flutter/flutter#146806) 2024-05-10 sokolovskyi.konstantin@gmail.com Add test for animated_size.0.dart API example. (flutter/flutter#147828) 2024-05-10 120297255+PurplePolyhedron@users.noreply.github.com Fix `DropdownMenu` keyboard navigation (flutter/flutter#147294) 2024-05-10 sokolovskyi.konstantin@gmail.com Add test for draggable.0.dart API example. (flutter/flutter#147941) 2024-05-10 magder@google.com Update TESTOWNERS (flutter/flutter#148108) 2024-05-10 sokolovskyi.konstantin@gmail.com Add tests for stream_builder.0.dart API example. (flutter/flutter#147832) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (flutter/flutter#148142) 2024-05-10 engine-flutter-autoroll@skia.org Roll Packages from 8de142d to 6c4482a (8 revisions) (flutter/flutter#148079) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (flutter/flutter#148137) 2024-05-10 nate.w5687@gmail.com `if` chains â�� `switch` expressions (flutter/flutter#147793) 2024-05-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/flutter#148091) 2024-05-10 31859944+LongCatIsLooong@users.noreply.github.com Reland "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#148086) 2024-05-10 magder@google.com Update dependabot reviewers (flutter/flutter#148101) 2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (flutter/flutter#148084) 2024-05-09 christopherfujino@gmail.com Don't pin package:macros (flutter/flutter#148087) 2024-05-09 ian@hixie.ch Remove hidden dependencies on the default LocalPlatform (flutter/flutter#147342) 2024-05-09 nate.w5687@gmail.com Getting rid of containers (flutter/flutter#147432) 2024-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (flutter/flutter#148070) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#6715) flutter/flutter@2aa05c1...1dfb46e 2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9e1a2c478d3 to 34fd28e8c7bd (1 revision) (flutter/flutter#148183) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 38a6ef7548f5 to a9e1a2c478d3 (2 revisions) (flutter/flutter#148176) 2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 558a81dd8b08 to 38a6ef7548f5 (1 revision) (flutter/flutter#148172) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
… with CocoaPods (flutter#6707) To keep the SwiftPM implementation more inline with CocoaPods, make all headers public.
|
auto label is removed for flutter/packages/6686, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/packages/6686, due to Pull request flutter/packages/6686 is not in a mergeable state. |
Updates the Android example app to use the replacement for the deprecated `getCountryCode`. Also udpates the deprecations method for `getCountryCode` to point to the correct variant of the platform interface method. Follow-up to flutter/flutter#147230
LouiseHsu
requested review from
hellohuanlin,
jmagman,
vashworth,
loic-sharma,
bparrishMines,
camsim99,
gmackall,
ditman,
chunhtai and
goderbauer
as code owners
|
I screwed up the merge w the SPM stuff somehow, gonna open a new pr lol |
Draft
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#141283
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).