Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker_android] - fix crash handle choose multi image result #6724

Closed

Conversation

Mairramer
Copy link
Contributor

This will fix flutter/flutter#147280 and complements the PR #6691

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@Mairramer Mairramer requested a review from gmackall as a code owner May 13, 2024 17:34
@Mairramer Mairramer changed the title Fix/crash handle choose multi image result [image_picker_android] - fix crash handle choose multi image result May 13, 2024
@gmackall
Copy link
Member

We've actually been meaning to change up the way we get the paths that end up being returned from the Intent, which I've just landed in #5009. Sorry for the conflict, but that PR also fixes the linked issue, so I'm going to close this.

I appreciate you taking the time to land the first fix and put up this fix as well, though!

@gmackall gmackall closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants