Do not merge - Run CI tests for SPM migration experiment 2 #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
May 15, 2024
| s.public_header_files = 'Classes/**/*.h' | ||
| s.module_map = 'Classes/CameraPlugin.modulemap' | ||
| s.source_files = 'camera_avfoundation/Sources/camera_avfoundation/**/*.{h,m}' | ||
| s.exclude_files = 'camera_avfoundation/Sources/camera_avfoundation/public/**/*.h' |
There was a problem hiding this comment.
This excludes the Swift package's public header files
loic-sharma
commented
May 15, 2024
| #import "FLTCam.h" | ||
| #import "messages.g.h" | ||
|
|
||
| /// APIs exposed for unit testing. | ||
| @interface CameraPlugin () | ||
| @interface CameraPlugin () <FCPCameraApi> |
There was a problem hiding this comment.
The plugin needs to implement the Pigeon API's FCPCameraApi. Previously the public header did this, but that meant the header file generated by Pigeon also needed to be public.
I switched this to follow file_selector_ios's pattern.
|
We decided not to go forward with this option, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.