-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_markdown] Added height and width to image builder #6739
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how image height and width are parsed from the markdown.
@domesticmouse |
Please add a test that covers width x height from markdown to final usage to prevent future breakage |
This was not done; please don't check boxes without completing the steps they describe.
CI indicates that the new test is not passing, which will need to be resolved before this can be reviewed. |
|
||
// Force the asset image to be rasterized so it can be compared. | ||
await tester.runAsync(() async { | ||
final Element element = tester.element(find.byType(Markdown)); | ||
await precacheImage(image.image, element); | ||
await precacheImage(image.image, element, | ||
size: Size(image.width!, image.height!)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if width
and height
are not specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes is same test result
I will remove it
I run image tests before any changes and I get :
Any advise please |
height
&width
toimageBuilder
.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).