Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding proper command for extracting archives #10610

Merged
merged 4 commits into from
May 16, 2024

Conversation

HicaroD
Copy link
Contributor

@HicaroD HicaroD commented May 15, 2024

Description of what this PR is changing or adding, and why:

Some commands for extracting files were wrong in the documentation. So I fixed these commands for Linux and macOS. For some weird reason, some flags, such as -C from tar command, were not showing, so I used multilines as a sorta of hack in order to make these flags appear, so I hope it is not a problem.

Also I removed the word zip from the description because the downloaded artifact may not be a zip file, therefore it could cause a slight confusion to the user, in my opinion.

Issues fixed by this PR (if any):
#10607

Presubmit checklist

Copy link

google-cla bot commented May 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parlough parlough added the review.tech Awaiting Technical Review label May 15, 2024
@atsansone
Copy link
Contributor

atsansone commented May 15, 2024

@HicaroD : Good catch! If you can sign the CLA, we can get this merged.

@atsansone atsansone added the cla: no Contributor has not signed the Contributor License Agreement label May 15, 2024
@google-cla google-cla bot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels May 15, 2024
@atsansone
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 5b3971f):

https://flutter-docs-prod--pr10610-fix-10607-59pskxc9.web.app

@atsansone atsansone merged commit c8f1d26 into flutter:main May 16, 2024
9 checks passed
@HicaroD
Copy link
Contributor Author

HicaroD commented May 16, 2024

I'm happy to contribute!

Thanks for reviewing @atsansone

@sethladd
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement review.tech Awaiting Technical Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants