Non dragable progress bar #498
Conversation
|
thx. I will run the CI, after it's green, we can merge this 👍🏼 |
it’s red. I will fix errors. |
Fixed. Can you run CI please ? |
still failing :/ |
|
@ensarkurrt looks like there's some conflicts with your changes preventing merging. Please resolve those first so that I can merge it into master. Otherwise, the change LGTM. @maherjaafar what say you regarding this change? Thanks in advance for this change |
|
@ensarkurrt also looks like CI was failing. Please ensure that it passes lint and formatting checks. Thanks. |
| @@ -263,6 +264,7 @@ class ChewieController extends ChangeNotifier { | |||
| double? aspectRatio, | |||
| bool? autoInitialize, | |||
| bool? autoPlay, | |||
| bool? draggableProgressBar, | |||
There was a problem hiding this comment.
| bool? draggableProgressBar, | |
| bool draggableProgressBar, |
| child: Center( | ||
| child: Container( | ||
| height: MediaQuery.of(context).size.height, | ||
| width: MediaQuery.of(context).size.width, | ||
| color: Colors.transparent, | ||
| child: CustomPaint( | ||
| painter: _ProgressBarPainter( | ||
| value: controller.value, | ||
| colors: widget.colors, | ||
| barHeight: widget.barHeight, | ||
| handleHeight: widget.handleHeight, | ||
| drawShadow: widget.drawShadow, | ||
| ), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
This could be extracted to a Getter and use it between the lines 122-137
Widget get centeredProgressBar => Center(
child: Container(
height: MediaQuery.of(context).size.height,
width: MediaQuery.of(context).size.width,
color: Colors.transparent,
child: CustomPaint(
painter: _ProgressBarPainter(
value: controller.value,
colors: widget.colors,
barHeight: widget.barHeight,
handleHeight: widget.handleHeight,
drawShadow: widget.drawShadow,
),
),
),
);
|
@diegotori thanks for your reply. I will fix the issues. |
Hi, i need to
non-draggable progress bar featureon player. And Chewie Player too for power :) So i modified this library. I hope you merge that feature. I missed addFeaturelabel. Sorry for that.