Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/casting #586

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/casting #586

wants to merge 3 commits into from

Conversation

48miles
Copy link

@48miles 48miles commented Dec 24, 2021

adding cast & copy to clipboard button to both Android and iOS default options.

@ekuleshov
Copy link
Contributor

With these changes the example app is crashing a lot on Android 12 device with errors like:

D/bonsoir (31569): [66895] Bonsoir failed to start discovery : 4
E/AndroidRuntime(31569): FATAL EXCEPTION: NsdManager
E/AndroidRuntime(31569): Process: com.example.example, PID: 31569
E/AndroidRuntime(31569): java.lang.IllegalArgumentException: listener not registered
E/AndroidRuntime(31569): 	at com.android.internal.util.Preconditions.checkArgument(Preconditions.java:59)
E/AndroidRuntime(31569): 	at android.net.nsd.NsdManager.getListenerKey(NsdManager.java:496)
E/AndroidRuntime(31569): 	at android.net.nsd.NsdManager.stopServiceDiscovery(NsdManager.java:636)
E/AndroidRuntime(31569): 	at fr.skyost.bonsoir.discovery.BonsoirDiscoveryListener.dispose(BonsoirDiscoveryListener.kt:167)
E/AndroidRuntime(31569): 	at fr.skyost.bonsoir.discovery.BonsoirDiscoveryListener.dispose$default(BonsoirDiscoveryListener.kt:165)
E/AndroidRuntime(31569): 	at fr.skyost.bonsoir.discovery.BonsoirDiscoveryListener.onStartDiscoveryFailed(BonsoirDiscoveryListener.kt:86)
E/AndroidRuntime(31569): 	at android.net.nsd.NsdManager$ServiceHandler.handleMessage(NsdManager.java:412)
E/AndroidRuntime(31569): 	at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime(31569): 	at android.os.Looper.loopOnce(Looper.java:201)
E/AndroidRuntime(31569): 	at android.os.Looper.loop(Looper.java:288)
E/AndroidRuntime(31569): 	at android.os.HandlerThread.run(HandlerThread.java:67)
I/flutter (31569): [CastDiscoveryService] error PlatformException - PlatformException(discovery_error, Bonsoir failed to start discovery, 4, null)

@diegotori
Copy link
Collaborator

@48miles please re-sync your changes with the latest master changes. Thanks.

@maherjaafar
Copy link
Collaborator

@48miles This branch has conflicts with the master branch, please resolve it.

@Ahmadre Ahmadre added this to To do in chewie 2.0 Apr 16, 2022
@arodriguezgb
Copy link

Any update on casting?

@maherjaafar
Copy link
Collaborator

Any update on casting?

@48miles could you fix the conflicts?

@dejancencelj
Copy link

Any update on casting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants