By default subtitles are off #700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone can have the folllow up ont this ?? |
|
@PranavMasekar Looks good to me. I'll release it this weekend. |
|
Sure thanks for the reply @diegotori 🤩🤩 |
|
@diegotori Any updates on merging this PR ?? |
1 similar comment
|
@diegotori Any updates on merging this PR ?? |
diegotori
requested changes
Jul 2, 2023
There was a problem hiding this comment.
@PranavMasekar, please re-sync your changes with master's current changes.
Then work on the issues that were called out in your PR.
Thanks in advance.
lib/src/chewie_player.dart
Outdated
| @@ -422,6 +425,9 @@ class ChewieController extends ChangeNotifier { | |||
| /// Add a List of Subtitles here in `Subtitles.subtitle` | |||
| Subtitles? subtitle; | |||
|
|
|||
| /// Option to disable subtitle by default | |||
| bool showSubtitle; | |||
lib/src/chewie_player.dart
Outdated
| @@ -422,6 +425,9 @@ class ChewieController extends ChangeNotifier { | |||
| /// Add a List of Subtitles here in `Subtitles.subtitle` | |||
| Subtitles? subtitle; | |||
|
|
|||
| /// Option to disable subtitle by default | |||
There was a problem hiding this comment.
Replace the documentation with:
///
/// Whether to display subtitles.
///
/// By default, this is set to `false`, which hides them.
///
|
@diegotori I have done the changes |
diegotori
requested changes
Jul 24, 2023
| @@ -114,6 +114,7 @@ class _ChewieDemoState extends State<ChewieDemo> { | |||
| videoPlayerController: _videoPlayerController1, | |||
| autoPlay: true, | |||
| looping: true, | |||
| // showSubtitle: true, | |||
There was a problem hiding this comment.
Instead of commenting it out, expand the example app so that there's a button or something similar that toggles subtitles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#648
Added a parameter showSubtitle by default value is false.