Added seek forward and rewind buttons #717

punit1111 · 2023-03-28T16:45:35Z

double tap or click to seek forward or rewind back 10 seconds
seek forward and rewind buttons added to video controls screen
are there other controls? #715

diegotori · 2023-07-02T21:42:55Z

@punit1111 Thank you for your PR.

Please re-sync your changes with the latest changes in master.

punit1111 · 2023-07-03T09:41:09Z

@punit1111 Thank you for your PR.

Please re-sync your changes with the latest changes in master.

@diegotori re-sync done please review the PR

Thank you

maherjaafar · 2023-07-03T12:45:42Z

lib/src/cupertino/cupertino_controls.dart

+        SeekRewindButton(
+          backgroundColor: Colors.black54,
+          iconColor: Colors.white,
+          show: showSeekButton,
+          onPressed: _seekRewind,
+          onDoublePressed: _seekRewind,
+          icon: Icons.fast_rewind,
+        ),


SeekRewindButtons between line 361-368 and 388-395 can be reusable. Please extract them to a Widget _buildSeekRewindButton({bool isSeekForward = true}).

maherjaafar · 2023-07-03T12:50:22Z

lib/src/cupertino/cupertino_controls.dart

+  void _seekForward() {
+    setState(() {
+      controller.seekTo(
+        Duration(
+          seconds: _latestValue.position.inSeconds + 10,
+        ),
+      );
+    });
+  }
+
+  void _seekRewind() {
+    setState(() {
+      controller.seekTo(
+        Duration(
+          seconds: _latestValue.position.inSeconds - 10,
+        ),
+      );
+    });
+  }


Duplicated code:

Suggested change

void _seekForward() {

setState(() {

controller.seekTo(

Duration(

seconds: _latestValue.position.inSeconds + 10,

),

);

});

}

void _seekRewind() {

setState(() {

controller.seekTo(

Duration(

seconds: _latestValue.position.inSeconds - 10,

),

);

});

}

void _seekTo({int seconds = 10}) {

setState(() {

controller.seekTo(

Duration(

seconds: _latestValue.position.inSeconds + seconds,

),

);

});

}

void _seekForward() => _seekTo();

void _seekRewind() => _seekTo(seconds: -10);

maherjaafar · 2023-07-03T12:51:55Z

lib/src/material/material_controls.dart

+    return Row(
+      mainAxisAlignment: MainAxisAlignment.center,
+      children: [
+        SeekRewindButton(
+          backgroundColor: Colors.black54,
+          iconColor: Colors.white,
+          show: showSeekButton,
+          onPressed: _seekRewind,
+          onDoublePressed: _seekRewind,
+          icon: Icons.fast_rewind,
+        ),
+        GestureDetector(
+          onTap: () {
+            if (_latestValue.isPlaying) {
+              if (_displayTapped) {
+                setState(() {
+                  notifier.hideStuff = true;
+                });
+              } else {
+                _cancelAndRestartTimer();
+              }
+            } else {
+              _playPause();
+
+              setState(() {
+                notifier.hideStuff = true;
+              });
+            }
+          },
+          child: CenterPlayButton(
+            backgroundColor: Colors.black54,
+            iconColor: Colors.white,
+            isFinished: isFinished,
+            isPlaying: controller.value.isPlaying,
+            show: showPlayButton,
+            onPressed: _playPause,
+          ),
+        ),
+        SeekRewindButton(
+          backgroundColor: Colors.black54,
+          iconColor: Colors.white,
+          show: showSeekButton,
+          onPressed: _seekForward,
+          onDoublePressed: _seekForward,
+          icon: Icons.fast_forward,
+        ),
+      ],


Duplicated code from the other file: lib/src/cupertino/cupertino_controls.dart

punit1111 · 2023-07-04T14:03:44Z

@maherjaafar requested changes are done. please review the PR

Thank you

diegotori · 2023-07-24T18:26:25Z

lib/src/hit_area_controls.dart

+  SeekRewindButton _buildSeekRewindButton({bool isSeekForward = true}) {
+    return SeekRewindButton(
+      backgroundColor: backgroundColor,
+      iconColor: iconColor,
+      show: showSeekButton,
+      onPressed: isSeekForward ? seekForward : seekRewind,
+      onDoublePressed: isSeekForward ? seekForward : seekRewind,
+      icon: isSeekForward ? Icons.fast_forward : Icons.fast_rewind,
+    );
+  }


Do not use methods to return widgets. Instead you can simply add SeekRewindButton as part of your Row children.

earlier it was inside a Row children. it's extracted into method as changes requested #717 (comment)

@maherjaafar just an FYI, according to this issue and the official documentation regarding this subject, large Widgets should be spun off into new ones instead of methods that return them.

That way, you'll be able to create them as consts, thus increasing performance since they won't have to be re-built when build is called again.

@punit1111 sorry for the extra work, but these widgets should ultimately be extracted as new StatelessWidgets instead of being computed from a method.

Please let me know if this clears up things.

@diegotori SeekRewindButton is already extracted as Stateless Widget lib/src/seek_rewind_button.dart

@punit1111 that is true, but instead of creating it from _buildSeekRewindButton, you should just replace those calls with the actual widget:

Change this:

_buildSeekRewindButton(isSeekForward: true),

to this:

SeekRewindButton( backgroundColor: backgroundColor, iconColor: iconColor, show: showSeekButton, onPressed: seekForward, onDoublePressed: seekForward, icon: Icons.fast_forward, )

Do likewise for the other places where that method is being called from.

diegotori · 2023-08-04T19:12:16Z

lib/src/seek_rewind_button.dart

@@ -0,0 +1,61 @@
+import 'package:flutter/material.dart';
+
+class SeekRewindButton extends StatefulWidget {


This should be renamed to SeekControlButton, so that it better reflects its stated purpose.

That way, you can create buttons that just configure that widget for its specific purpose:

class SeekRewindButton extends StatefulWidget { const SeekRewindButton({ super.key, required this.backgroundColor, this.iconColor, required this.show, this.onPressed, this.onDoublePressed, this.icon = const Icons.fast_rewind, }); final Color backgroundColor; final Color? iconColor; final bool show; final VoidCallback? onPressed; final VoidCallback? onDoublePressed; final IconData icon; Widget build(BuildContext context) { return SeekControlButton( backgroundColor: backgroundColor, iconColor: iconColor, show: show, icon: icon, onPressed: onPressed, onDoublePressed: onDoublePressed, ); } }

Do likewise for the fast-forward button: (i.e. SeekFastForwardButton).

diegotori · 2023-08-04T19:14:21Z

lib/src/seek_rewind_button.dart

+  final bool show;
+  final VoidCallback? onPressed;
+  final VoidCallback? onDoublePressed;
+  final IconData? icon;


If required, make it non-nullable.

punit1111 · 2023-08-05T06:21:57Z

Hi @diegotori

please review the Changes and let me know if anything needs to be fixed

Thank you

diegotori · 2023-08-07T14:45:23Z

lib/src/cupertino/cupertino_controls.dart

-      child: CenterPlayButton(
-        backgroundColor: widget.backgroundColor,
-        iconColor: widget.iconColor,
-        isFinished: isFinished,
-        isPlaying: controller.value.isPlaying,
-        show: showPlayButton,
-        onPressed: _playPause,
-      ),


Cupertino controls already have the seek-forward and rewind buttons in the seek bar (i.e. the ones that rewind and fast-forward by 15 seconds).

As a result, this change should only apply to Material based widgets.

Do this for the other new widgets added in this PR, since they should only apply to Material.

Hello @diegotori

requested changes done please review

Thank you

diegotori

LGTM

diegotori · 2023-08-30T21:40:03Z

@maherjaafar please give this PR one last look before I can finalize this change.

Thanks.

ameya730 · 2024-01-10T04:16:21Z

Hi,
Any update on when this branch will be pushed.
Regards,
Ameya

punit1111 and others added 2 commits March 28, 2023 22:09

Added seek forward and rewind buttons

ac80825

Update seek_rewind_button.dart

e34033c

Merge branch 'fluttercommunity:master' into master

a847292

maherjaafar reviewed Jul 3, 2023

View reviewed changes

code refactor

70a5875

punit1111 requested a review from maherjaafar July 5, 2023 05:33

diegotori requested changes Jul 24, 2023

View reviewed changes

diegotori reviewed Aug 4, 2023

View reviewed changes

punit1111 and others added 2 commits August 5, 2023 11:24

Merge branch 'fluttercommunity:master' into master

ab57910

fixed changes

ca7a04f

punit1111 requested a review from diegotori August 5, 2023 06:20

diegotori requested changes Aug 7, 2023

View reviewed changes

hide seek buttons for cupertino controls

e9daf6b

punit1111 requested a review from diegotori August 25, 2023 13:04

diegotori approved these changes Aug 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added seek forward and rewind buttons #717

Added seek forward and rewind buttons #717

punit1111 commented Mar 28, 2023 •

edited

diegotori commented Jul 2, 2023

punit1111 commented Jul 3, 2023 •

edited

maherjaafar Jul 3, 2023 •

edited

maherjaafar Jul 3, 2023 •

edited

maherjaafar Jul 3, 2023

punit1111 commented Jul 4, 2023

diegotori Jul 24, 2023

punit1111 Jul 25, 2023

diegotori Aug 2, 2023 •

edited

punit1111 Aug 3, 2023

diegotori Aug 4, 2023 •

edited

diegotori Aug 4, 2023

diegotori Aug 4, 2023

diegotori Aug 4, 2023

punit1111 commented Aug 5, 2023

diegotori Aug 7, 2023

punit1111 Aug 25, 2023

diegotori left a comment

diegotori commented Aug 30, 2023

ameya730 commented Jan 10, 2024

		@@ -0,0 +1,61 @@
		import 'package:flutter/material.dart';

		class SeekRewindButton extends StatefulWidget {

Added seek forward and rewind buttons #717

Are you sure you want to change the base?

Added seek forward and rewind buttons #717

Conversation

punit1111 commented Mar 28, 2023 • edited

diegotori commented Jul 2, 2023

punit1111 commented Jul 3, 2023 • edited

maherjaafar Jul 3, 2023 • edited

Choose a reason for hiding this comment

maherjaafar Jul 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

punit1111 commented Jul 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diegotori Aug 2, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diegotori Aug 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

punit1111 commented Aug 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diegotori left a comment

Choose a reason for hiding this comment

diegotori commented Aug 30, 2023

ameya730 commented Jan 10, 2024

punit1111 commented Mar 28, 2023 •

edited

punit1111 commented Jul 3, 2023 •

edited

maherjaafar Jul 3, 2023 •

edited

maherjaafar Jul 3, 2023 •

edited

diegotori Aug 2, 2023 •

edited

diegotori Aug 4, 2023 •

edited