Fixed orientation issue when exiting full screen mode #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
requested changes
Apr 1, 2024
Comment on lines
-61
to
-70
| @override | ||
| void didUpdateWidget(Chewie oldWidget) { | ||
| if (oldWidget.controller != widget.controller) { | ||
| widget.controller.addListener(listener); | ||
| } | ||
| super.didUpdateWidget(oldWidget); | ||
| if (_isFullScreen != isControllerFullScreen) { | ||
| widget.controller._isFullScreen = _isFullScreen; | ||
| } | ||
| } |
There was a problem hiding this comment.
There's no need to remove this, since if you refresh the widget with new properties, then removing this code won't update this StatefulWidget with them.
Comment on lines
+558
to
+561
| SystemChrome.setPreferredOrientations([ | ||
| DeviceOrientation.portraitUp, | ||
| DeviceOrientation.portraitDown, | ||
| ]); |
There was a problem hiding this comment.
The controller should not be responsible for setting SystemChrome whatsoever.
This should be moved into ChewieState and called before calling this method.
Also, it should not assume that it will fall back to Portrait. Instead, there's an option in the ChewieController called deviceOrientationsAfterFullScreen that it should be set to instead.
Comment on lines
-176
to
-182
| SystemChrome.setEnabledSystemUIMode( | ||
| SystemUiMode.manual, | ||
| overlays: widget.controller.systemOverlaysAfterFullScreen, | ||
| ); | ||
| SystemChrome.setPreferredOrientations( | ||
| widget.controller.deviceOrientationsAfterFullScreen, | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #812 .
Problem:
When exiting fullscreen mode in the video player, the app was not returning to portrait orientation as expected.
Solution:
I've implemented a fix that ensures the app returns to portrait orientation after exiting fullscreen mode in the video player.
Additionally, I've tested this fix and verified that it resolves the issue.
Fixes: #812