Add text column db #209

mohammadne · 2019-12-26T09:38:06Z

in my use case I have to add additional info to task table (very necessary for me).
refer to issue #195
so I open my first pull request in open source.
then I try to download but it will fail.
if anyone can help me that's a good encouragement for me.

Thanks to the community.

hnvn · 2019-12-27T06:11:24Z

Awesome. I will look at it. Thanks for your contribution

hnvn · 2019-12-28T08:43:34Z

Have you tested on iOS yet? On the iOS side, to modify the database schema, you need to update the sql file too. And what about DB migration? If current projects upgrade to this new DB, does it still work?

hnvn · 2019-12-28T08:45:50Z

Btw, I've used sqlitebrowser to create that sql file

mohammadne · 2019-12-28T19:18:23Z

Hi hnvn.
No, I don't test it on ios.
So what do we should do?

I think this is necessary in most projects which uses flutter downloader.

hnvn · 2019-12-29T03:43:59Z

Working with SQLite in iOS is painful. I concern that modifying DB schema might break the current features.

mohammadne · 2019-12-29T15:13:32Z

Ok, Thanks a lot hnvn for attention.
If you decide to modify DB, I will test it on both ios and Android to see does it break current features or not.
But if you can't, I hope someone can modify the DB.

hnvn · 2019-12-31T01:59:56Z

Thanks for your contribution. My priority now is to migrate this plugin to embedding v2, then I will get back to this issue and try to find a solution for it.

mohammadne · 2020-01-17T13:51:58Z

Thanks for your plugin migration.
Is it possible to find a solution for this?

befora · 2020-01-18T02:41:39Z

@mohammadne Do you use this to store json data? I'm looking for something that could do that instead of writing it externally and keeping two separate date sources in sync.

mohammadne · 2020-02-06T16:34:39Z

any Update on this ???

781flyingdutchman · 2020-03-27T01:51:48Z

If you need to store additional information related to a task (and that information is not related to downloading the task) then I think you should create an additional database or map that has taskId as its key and whatever fields you want to add. I don't think you should add functionality or features to the downloader task database that are not strictly required for or related to the download functionality

markturnip · 2020-07-22T04:24:20Z

Sorry to bump?

alr2413 · 2020-07-27T11:17:34Z

Hi,

I think the better idea is to define a list of parameters like Map<String,String> and before storing in database use method like "json_encode" to convert that list to string, and when retrieving from database convert it back to list by "json_decode".
Also, maybe we can also use an extra column like 'description' column in tasks database for this purpose. Adding description column to database is common in programming and can be used for different goals like this.

I'm looking forward to hearing from you guys.
Thanks.

mr-mmmmore · 2021-02-15T08:39:47Z

Hey @hnvn, what must be done so this PR gets merged? I also need it and it seems that most of the job is done here, isn't it?

I am willing to contribute if I can.

mr-mmmmore · 2021-02-15T09:29:16Z

Working with SQLite in iOS is painful. I concern that modifying DB schema might break the current features.

What are you afraid of @hnvn? Since this is a new column I don't see how it could break any feature as no pre-existing code rely on it.

I see that at the moment the plugin simply deletes the previous database in Android when a migration of the database is required (TaskDbHelper.onUpgrade), couldn't the same be done on iOS? (Although it's quite rude... it would be rather simple to only alter the table upon migration on Android, on iOS I don't know, it seems to be less automatic).

abeyshiferaw0 · 2021-11-05T07:38:14Z

Hi, is this a tested fork, does it work on both android and ios, if it does it should be merged with the main project, it a very crucial features, how are we supposes to track what our apps download if there is noting unique we can add in the tasks db, so pls @hnvn can you inform us if we should use this fork or if we should wait till it can be merged.

mr-mmmmore · 2021-11-05T08:30:36Z

Alas it seems that nothing has happen on this matter. I have had to implement my own persistent db in parallel to keep track of the "loading task"/"app entity" mapping and it has been a real pain to keep it in sync with the plugin's one. If someone could finish this PR all this work could be avoided (I didn't because I am not myself an iOS developer).

I had created another issue where I describe the problems that such a feature would solve: #402.

bartekpacia

Thanks for this PR. Please take a look at my comments and fix the merge conflicts.

Also, please consider implementing improvements mentioned in this comment.

bartekpacia · 2022-08-17T15:59:59Z

android/.project

+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>android</name>
+	<comment>Project android created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>


Looks like an autogenerated file included by mistake - please delete it.

bartekpacia · 2022-08-17T16:00:07Z

android/.settings/org.eclipse.buildship.core.prefs

+arguments=
+auto.sync=false
+build.scans.enabled=false
+connection.gradle.distribution=GRADLE_DISTRIBUTION(VERSION(6.0-20191016123526+0000))
+connection.project.dir=
+eclipse.preferences.version=1
+gradle.user.home=
+java.home=/usr/lib/jvm/java-11-openjdk-amd64
+jvm.arguments=
+offline.mode=false
+override.workspace.settings=true
+show.console.view=true
+show.executions.view=true


bartekpacia · 2022-08-17T16:00:44Z

android/src/main/java/vn/hunghd/flutterdownloader/DownloadTask.java

                 String headers, String mimeType, boolean resumable, boolean showNotification, boolean openFileFromNotification, long timeCreated) {
        this.primaryId = primaryId;
        this.taskId = taskId;
        this.status = status;
        this.progress = progress;
        this.url = url;
        this.filename = filename;
+        this.additionalinfo = additionalinfo;


I'd rename this field to extra.

bartekpacia · 2022-08-17T16:01:20Z

example/.vscode/launch.json

+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Flutter",
+            "request": "launch",
+            "type": "dart"
+        }
+    ]
+}


Please delete this file.

bartekpacia · 2022-08-17T16:01:29Z

example/android/.project

+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>android</name>
+	<comment>Project android created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>


Please delete.

bartekpacia · 2022-08-17T16:01:43Z

example/android/app/.classpath

+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11/"/>
+	<classpathentry kind="con" path="org.eclipse.buildship.core.gradleclasspathcontainer"/>
+	<classpathentry kind="output" path="bin/default"/>
+</classpath>


Same as above.

bartekpacia · 2022-08-17T16:01:51Z

example/android/app/.project

+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>app</name>
+	<comment>Project app created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>


Please delete.

bartekpacia · 2022-08-17T16:02:08Z

example/android/app/.settings/org.eclipse.buildship.core.prefs

+connection.project.dir=..
+eclipse.preferences.version=1


😕 please remove this file

bartekpacia · 2022-08-17T16:02:29Z

example/ios/Flutter/flutter_export_environment.sh

@@ -1,5 +1,6 @@
 #!/bin/sh
 # This is a generated file; do not edit or check into version control.
+


Rever this change.

bartekpacia · 2022-08-17T16:06:33Z

lib/src/models.dart

@@ -34,6 +34,7 @@ class DownloadTaskStatus {
 /// * [progress] the latest progress value of a download task
 /// * [url] the download link
 /// * [filename] the local file name of a downloaded file
+/// * [additionalInfo] Additional information of a downloaded file


Maybe change to something like Optional, extra string associated with this task

Mr.Nasr added 4 commits December 26, 2019 11:25

dart additional info

8bcac5c

android part

06a1bab

obj c

c9cc84c

for test

ffda03c

Merge branch 'master' into add-text-column-db

0063fac

markturnip mentioned this pull request Jul 22, 2020

Keep metaData sync with download Tasks #239

Open

bartekpacia requested changes Aug 17, 2022

View reviewed changes

Karim0x1 mentioned this pull request Oct 23, 2022

Add extras column db #739

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add text column db #209

Add text column db #209

mohammadne commented Dec 26, 2019 •

edited

hnvn commented Dec 27, 2019

hnvn commented Dec 28, 2019

hnvn commented Dec 28, 2019

mohammadne commented Dec 28, 2019 •

edited

hnvn commented Dec 29, 2019

mohammadne commented Dec 29, 2019

hnvn commented Dec 31, 2019

mohammadne commented Jan 17, 2020

befora commented Jan 18, 2020

mohammadne commented Feb 6, 2020

781flyingdutchman commented Mar 27, 2020

markturnip commented Jul 22, 2020

alr2413 commented Jul 27, 2020

mr-mmmmore commented Feb 15, 2021

mr-mmmmore commented Feb 15, 2021

abeyshiferaw0 commented Nov 5, 2021

mr-mmmmore commented Nov 5, 2021

bartekpacia left a comment •

edited

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

bartekpacia Aug 17, 2022

		@@ -1,5 +1,6 @@
		#!/bin/sh
		# This is a generated file; do not edit or check into version control.

		connection.project.dir=..
		eclipse.preferences.version=1

Add text column db #209

Are you sure you want to change the base?

Add text column db #209

Conversation

mohammadne commented Dec 26, 2019 • edited

hnvn commented Dec 27, 2019

hnvn commented Dec 28, 2019

hnvn commented Dec 28, 2019

mohammadne commented Dec 28, 2019 • edited

hnvn commented Dec 29, 2019

mohammadne commented Dec 29, 2019

hnvn commented Dec 31, 2019

mohammadne commented Jan 17, 2020

befora commented Jan 18, 2020

mohammadne commented Feb 6, 2020

781flyingdutchman commented Mar 27, 2020

markturnip commented Jul 22, 2020

alr2413 commented Jul 27, 2020

mr-mmmmore commented Feb 15, 2021

mr-mmmmore commented Feb 15, 2021

abeyshiferaw0 commented Nov 5, 2021

mr-mmmmore commented Nov 5, 2021

bartekpacia left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohammadne commented Dec 26, 2019 •

edited

mohammadne commented Dec 28, 2019 •

edited

bartekpacia left a comment •

edited