fix: on iOS db locked error #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf521c8.
… background isolate plugin 2. loadDataFromDB in `loadTaskWithId` safely
…`, because the front lines return when `openDatabaseResult != SQLITE_OK`
…teInDatabaseQueueForTask]
|
Hi @salmaahhmed , would you mind reviewing the pr sometime? My project is still troubled by the problem, others may also be so. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore previous comments.
Failure causes:
The cause of the failure was the creation of two FlutterDownloaderPlugin, main plugin and background isolate plugin. Since
dispatch_queue_t databaseQueueis instance object, two queues were also created with the plugins, there are also two queues to access the database so that data race in database.loadDataFromDBinloadTaskWithIdis exposed on any queue.Current
Fixed