Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Run flutter analyze workflow in proper scopes and enforce its results #2775

Open
vbuberen opened this issue Mar 30, 2024 · 0 comments
Labels
enhancement New feature or request triage

Comments

@vbuberen
Copy link
Collaborator

Plugin

All

Use case

It makes no sense to run analyze on all packages in every PR.

Here is an example where in PR with device_info_plus files changes only I see warnings for another plugin, because the analyze task runs for all plugins:
Screenshot 2024-03-30 at 15 13 29

Proposal

Suggest to do multiple changes:

  • Run analyze only in the scope of changed files in PRs.
  • Make analyzer warnings failing the set of CI checks to enforce issues resolutions, instead of catching up with fixes later as we do now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant