Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(all): Analyze every package individually #2852

Merged
merged 1 commit into from Apr 23, 2024
Merged

Conversation

vbuberen
Copy link
Collaborator

Description

Don't see much value in analyze for all packages as it would be more appropriate to analyze every individual package when changed. Thus, modified workflows to do exactly this.
Didn't change infos to fatal state as it seemed too much, but maybe forcing even infos might be good to be sure that we and other contributors resolve lint issues right away.

Related Issues

Part of #2775

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it was always a bit confusing to see warnings from another package

@vbuberen vbuberen merged commit 2e1a394 into main Apr 23, 2024
98 of 108 checks passed
@vbuberen vbuberen deleted the refactor/analyzer_setup branch April 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants