Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(network_info_plus): Update Kotlin, Gradle and add Dependabot config #1267

Merged
merged 6 commits into from Oct 19, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

Same as #1261 - updating Kotlin, Gradle and adding a Dependabot config for Android dependencies.

Related Issues

#1248
#1222

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

.github/dependabot.yml Outdated Show resolved Hide resolved
@@ -43,7 +43,7 @@ updates:
prefix: "chore"
include: "scope"

# Android Intent Plus dependencies updates config
# Android Intent Plus dependencies updates config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in whitespace can be discarded to match the other indentations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just rely on autoformat to have the file following the editorconfig file we have in the root of the project. Because current discrepancies are mainly caused by me editing this yaml file right here on Github for some PRs, while for others using my IDE.

@vbuberen vbuberen merged commit 57724e3 into main Oct 19, 2022
@vbuberen vbuberen deleted the update/network_info_plus branch October 19, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants