build(share_plus): Update to target and compile SDK 34 on Android #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
added
the
share_plus
vbuberen
commented
Mar 16, 2024
| Intent.createChooser(shareIntent, null /* dialog title optional */) | ||
| } | ||
| val chooserIntent = | ||
| if (withResult && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP_MR1) { |
There was a problem hiding this comment.
Added version check to not see lint errors when working with Android part.
This change influences nothing, because we have the same check in the method call handler class.
vbuberen
commented
Mar 16, 2024
| Intent.createChooser(shareIntent, null /* dialog title optional */) | ||
| } | ||
| val chooserIntent = | ||
| if (withResult && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP_MR1) { |
There was a problem hiding this comment.
Added version check to not see lint errors when working with Android part.
This change influences nothing, because we have the same check in the method call handler class.
vbuberen
commented
Mar 16, 2024
| @@ -28,6 +28,7 @@ internal class SharePlusPendingIntent: BroadcastReceiver() { | |||
| intent.getParcelableExtra(Intent.EXTRA_CHOSEN_COMPONENT, ComponentName::class.java) | |||
| } else { | |||
| // Deprecated in API level 33 | |||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
Just to not see lint warnings
miquelbeltran
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #2701 but with a few additional fixes for the example app.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).