-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(device_info_plus): Add isLowRamDevice property to AndroidDeviceInfo #2765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thanks for providing an implementation for this!
There are a couple of things that should be changed before we can approve this PR.
Please take a look at the comments left.
...o_plus/android/src/main/kotlin/dev/fluttercommunity/plus/device_info/DeviceInfoPlusPlugin.kt
Outdated
Show resolved
Hide resolved
packages/device_info_plus/device_info_plus/lib/src/model/android_device_info.dart
Outdated
Show resolved
Hide resolved
packages/device_info_plus/device_info_plus/lib/src/model/android_device_info.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: K. P. Krasiński-Sroka <kpsroka@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! all good to go
Could be due to the |
Reference to reported bug, explained how I resolved it. |
Description
The idea is to detect whether the running device is on low RAM or not. From
ActivityManager
we are gettingisLowRamDevice()
which is added onAndroidDeviceInfo
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).