Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connectivity_plus): remove ReachabilityConnectivityProvider and ReachabilitySwift dependency #2813

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Apr 4, 2024

Description

  • The min OS versions used are iOS: 12 and macOS: 10.14.
  • At the same time, the min OS versions to use the NWPathProvider implementation are also 12 and 10.14.
  • The old implementation that users ReachibilitySwift is not being used because the app will always use the NWPathProvider implementation.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran marked this pull request as ready for review April 4, 2024 06:19
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I remember how this thing caused issues to us some time ago. Glad to see it going.

@miquelbeltran miquelbeltran merged commit f9ad927 into main Apr 4, 2024
21 checks passed
@miquelbeltran miquelbeltran deleted the miquelbeltran/2779 branch April 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Remove Reachability implementation from connectivity_plus ios & macos (darwin)
2 participants