Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): WASM-compatible conditional imports #2826

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

IchordeDionysos
Copy link
Contributor

Description

Migrates the conditional imports to support WASM (see https://dart.dev/interop/js-interop/package-web#conditional-imports)

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

Thanks for taking care of this @IchordeDionysos !

Also, thanks for making separate PRs per package.

I will merge the three PRs.

@miquelbeltran miquelbeltran merged commit 11200cf into fluttercommunity:main Apr 7, 2024
17 of 19 checks passed
@IchordeDionysos IchordeDionysos deleted the patch-3 branch April 7, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incomplete migration of conditional imports to WASM-compatible js-interop
2 participants