refactor(share_plus)!: Share API cleanup #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
changed the title
miquelbeltran
changed the title
miquelbeltran
commented
Apr 10, 2024
| if (isWithResult && !manager.setCallback(result)) return | ||
| if (isWithResult) | ||
| manager.setCallback(result) |
There was a problem hiding this comment.
this is part of the change that fixes any possible deadlocks, since setCallback will force any pending call to be returned with an "unavailable" ShareResult
miquelbeltran
commented
Apr 10, 2024
Comment on lines
-28
to
+35
| callback.error( | ||
| "Share callback error", | ||
| "prior share-sheet did not call back, did you await it? Maybe use non-result variant", | ||
| null, | ||
| ) | ||
| false | ||
| // Ensure no deadlocks. | ||
| // Return result of any waiting call. | ||
| // e.g. user called to `share` but did not await for result. | ||
| this.callback?.success(RESULT_UNAVAILABLE) | ||
|
|
||
| // Prepare all state for new share | ||
| SharePlusPendingIntent.result = "" | ||
| isCalledBack.set(false) | ||
| this.callback = callback |
There was a problem hiding this comment.
instead of failing with an error, the call to share that is waiting for a response will get a ShareResult.unavailable, and the new call would be properly registered
8 tasks
Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com>
Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com>
|
Good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a major cleanup of the
share_plusplugin.In detail:
shareUri,shareandshareXFiles(removed deprecated methods).ShareResult.ShareSuccessManagerso it would not deadlock users anymore, instead, calling tosharewhile there is another call waiting, causes that the previous call will be called back withShareResult.unavailable, instead of causing an error.ShareResultcorrectly returned.ShareResultcorrectly.ShareResult.undefinedor throw an exception on error. Do not hide errors.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).