Limit crd-controller access to installed CRDs #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the access given to the crd-controler ClusterRole based on the enabled flux components. Similarly create ClusterRoleBinding only when the target component and SA is enabled. Signed-off-by: Nikolaos Parasyris <git@nikparasyr.com> Signed-off-by: nikParasyr <nik.parasyr@protonmail.com>
| @@ -13,21 +13,31 @@ metadata: | |||
| app.kubernetes.io/part-of: flux | |||
| helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} | |||
| rules: | |||
| {{- if .Values.sourceController.create }} | |||
There was a problem hiding this comment.
This is not Ok, as all other controllers need access to sources.
There was a problem hiding this comment.
My assumption was that the source controller will also be installed via the helm chart in that case and therefore this flag will be true.
Do we also facilitate cases where a subset of the controllers is installed through the helm chart and others are installed differently? Cause if that is the case then this PR needs to be re-assessed ( from my side )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Limit the access given to the crd-controler ClusterRole based on the enabled flux components. Similarly create ClusterRoleBinding only when the target component and SA is enabled.
Checklist
make reviewable