Introduce ScalerReconciler and refactor HPA reconciliation
#1211
+763
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
- Coverage 54.96% 54.77% -0.20%
==========================================
Files 79 80 +1
Lines 6642 6839 +197
==========================================
+ Hits 3651 3746 +95
- Misses 2418 2514 +96
- Partials 573 579 +6
Continue to review full report at Codecov.
|
added 3 commits
June 7, 2022 13:43
…troller Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
force-pushed
the
scaler-reconciler
branch
from
5d052fc to
9b97bff
Compare
stefanprodan
added
the
kind/enhancement
stefanprodan
reviewed
Jun 7, 2022
stefanprodan
reviewed
Jun 7, 2022
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works> for objectmeta as well
aryan9600
force-pushed
the
scaler-reconciler
branch
from
3fa1892 to
e0e2d5c
Compare
stefanprodan
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new interface
ScalerReconciler, which provides methods to reconcile a scaler like HPAs, or KEDA ScaledObjects. For now, the existing HPA reconciliation logic has been refactored to implement this, is moved out of the deployment controller and is used directly in the main reconciliation loop.