Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running traffic increase hooks after the last increase step has already been completed (and analyzed) #1500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pereiratps
Copy link

This PR is an improvement on the PR #1470 which was released in version v1.33.0.

The goal is for the traffic increase webhook to only run when the next step is actually a traffic increase.

Without this change, Flagger will still be calling the traffic increase webhook even after the last increase step has already been analyzed, right before the verification promotion webhook.

The code logic can be compared with the promotion webhook call (already on the code):

if canaryWeight >= maxWeight {
// check promotion gate
if promote := c.runConfirmPromotionHooks(canary, canaryController); !promote {
return
}

…ng after the last increase has already been done

Signed-off-by: Thiago Pereira de Souza <tpsouzajob@gmail.com>
@pereiratps pereiratps reopened this Aug 30, 2023
…heck

Signed-off-by: Thiago Pereira de Souza <tpsouzajob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant