add maxConcurrentCanaries flag to limit concurrent progressing canaries #1568
+143
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louishalbritter
force-pushed
the
limit-concurrent-canaries
branch
from
fb1f5b5
to
bec06ec
Compare
stefanprodan
reviewed
Feb 7, 2024
|
Please rebase with main and force push instead of merging, this PR should have a single commit. |
louishalbritter
force-pushed
the
limit-concurrent-canaries
branch
2 times, most recently
from
365fa1d
to
5dd58b7
Compare
louishalbritter
force-pushed
the
limit-concurrent-canaries
branch
from
00af576
to
03cfb87
Compare
This adds a flag to limit concurrent progessing canaries to avoid high requests of resources at once. The flag will not take effect if set to "0", which is default. Closes fluxcd#1069 Signed-off-by: Louis Halbritter <halbritter@posteo.de> chore: update Helm default values and README Signed-off-by: Louis Halbritter <halbritter@posteo.de>
louishalbritter
force-pushed
the
limit-concurrent-canaries
branch
from
29fd239
to
8b6cf92
Compare
|
I cleaned to git history up again. Can you please merge or deny this pull request? |
|
hey @louishalbritter, sorry this has been pending for a long time. i'll try to take a look this week. generally, we try to avoid making changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag to limit concurrent progessing canaries to avoid high requests of resources at once.
The flag will not take effect if set to "0", which is default.
Closes #1069