This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Filter files before SOPS decryption #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squaremo
reviewed
Aug 17, 2020
| @@ -207,7 +208,7 @@ func loadFile(path string, sopsEnabled bool) ([]byte, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if sopsEnabled { | |||
| if sopsEnabled && strings.Contains(string(bytes), "sops:") { | |||
There was a problem hiding this comment.
bytes.Contains(bytes, []byte("sops:"))
There was a problem hiding this comment.
(you'll have to rename the variable of course)
stefanprodan
force-pushed
the
filter-sops
branch
2 times, most recently
from
436abc6
to
a9cd969
Compare
|
/rebase |
Decrypt YAMLs with SOPS only if the file has a 'sops' field, this should speed up the apply time for large repositories.
github-actions
bot
force-pushed
the
filter-sops
branch
from
e856f43
to
59fcadd
Compare
squaremo
approved these changes
Aug 17, 2020
This was referenced Aug 17, 2020
redbaron
reviewed
Sep 3, 2020
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if sopsEnabled { | ||
| return softDecrypt(bytes) | ||
| if sopsEnabled && bytes.Contains(fileBytes, []byte("sops:")) { |
There was a problem hiding this comment.
unlikely to be triggered IRL, but this disables sops for JSON-like content of yaml files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: