Skip to content

Commit

Permalink
make gpg signing more robust for bootstrap
Browse files Browse the repository at this point in the history
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
  • Loading branch information
aryan9600 committed Nov 10, 2022
1 parent 7640fa5 commit dd6ddf2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
10 changes: 9 additions & 1 deletion pkg/bootstrap/bootstrap_plain_git.go
Expand Up @@ -430,13 +430,21 @@ func getOpenPgpEntity(keyRing openpgp.EntityList, passphrase, keyID string) (*op

var entity *openpgp.Entity
if keyID != "" {
if strings.HasPrefix(keyID, "0x") {
keyID = strings.TrimPrefix(keyID, "0x")
}
if len(keyID) != 16 {
return nil, fmt.Errorf("invalid GPG key id length; expected %d, got %d", 16, len(keyID))
}
keyID = strings.ToUpper(keyID)

for _, ent := range keyRing {
if ent.PrimaryKey.KeyIdString() == keyID {
entity = ent
}
}

if entity == nil {
if entity == nil || entity.PrivateKey == nil {
return nil, fmt.Errorf("no GPG private key matching key id '%s' found", keyID)
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion pkg/bootstrap/options.go
Expand Up @@ -155,7 +155,7 @@ func LoadEntityListFromPath(path string) (openpgp.EntityList, error) {
}
entityList, err := openpgp.ReadKeyRing(r)
if err != nil {
return nil, err
return nil, fmt.Errorf("unable to read GPG key ring: %w", err)
}
return entityList, nil
}

0 comments on commit dd6ddf2

Please sign in to comment.