Add bootstrap option to set a prefix for the commit messages #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dries Verachtert <dries.verachtert@dries.eu>
|
I've added the Signed-off-by in the commit message. |
hiddeco
reviewed
Apr 26, 2021
There was a problem hiding this comment.
Thank you for submitting a PR 🍰
I think that if there is a need to be able to control both the prefix and the appendix of the Git commit message, it would probably be better to deprecate the -appendix flag in favor of one that allows you to configure a full Git commit message template. Given this would prevent a wild-growth of commit message related flags that all modify different parts of the message.
|
hello, so how can i set a prefix for the commit messages only for bootstrap now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flux bootstrap already has an option to set a suffix for the commit messages. This change also adds a prefix. It's handy in environments where commit messages have to start with some ticket number for example.
I'm not a go developer: I basically copied the code of the 'commitMessageAppendix' option.
Signed-off-by: Dries Verachtert dries.verachtert@dries.eu