Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case on hpa metrics for flux build/diff #2370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test case on hpa metrics for flux build/diff #2370

wants to merge 1 commit into from

Conversation

souleb
Copy link
Member

@souleb souleb commented Feb 2, 2022

If implemented will detect any change on how ssa dry-run return diffs on
hpa metrics

Signed-off-by: Soule BA soule@weave.works

@stefanprodan
Copy link
Member

Can you please add a custom metric to the test:

  metrics:
    - pods:
        metric:
          name: nginx_http_requests_total
        target:
          averageValue: "4"
          type: AverageValue
      type: Pods

This was tripping diff in my tests, when other things change this custom metric gets duplicated in the diff output.

@souleb
Add test case on hpa metrics for flux build/diff
204a8fb 
If implemented will detect any change on how ssa dry-run return diffs on
hpa metrics

Signed-off-by: Soule BA <soule@weave.works>
stefanprodan
stefanprodan reviewed Feb 2, 2022
View reviewed changes
cmd/flux/testdata/diff-kustomization/diff-with-drifted-hpa.golden
type: Utilization
averageUtilization: 98

+ two list entries added:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this shouldn't happen.

@souleb souleb added the area/diff Diff related issues and pull requests label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/diff Diff related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@souleb @stefanprodan