Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-git to enable multi_ack #3225

Closed
wants to merge 1 commit into from
Closed

Bump go-git to enable multi_ack #3225

wants to merge 1 commit into from

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Oct 19, 2022

This enables the use of flux bootstrap git for Azure DevOps.

Tested with:

flux bootstrap git --url https://<ORG>@dev.azure.com/<ORG>/<REPO>/_git/<REPO> --username <USER_NAME> --password "${azure_pass}" --token-auth
► cloning branch "main" from Git repository "https://<ORG>@dev.azure.com/<ORG>/<REPO>/_git/<REPO>"
✔ cloned repository
► generating component manifests
✔ generated component manifests
✔ component manifests are up to date
► installing components in "flux-system" namespace
✔ installed components
✔ reconciled components
► determining if source secret "flux-system/flux-system" exists
► generating source secret
► applying source secret "flux-system/flux-system"
✔ reconciled source secret
► generating sync manifests
✔ generated sync manifests
✔ committed sync manifests to "main" ("e7c36489b9c232aca7c29f19b9a09db1cd01f189")
► pushing sync manifests to "https://<ORG>@dev.azure.com/<ORG>/<REPO>/_git/<REPO>"
► applying sync manifests
✔ reconciled sync configuration

⚠️ To work effectively it needs --git-implementation=libgit2 until the changes in git-refactoring are merged into main and released.

This enables the use of `flux bootstrap git` for Azure DevOps.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf added the area/git Git related issues and pull requests label Oct 19, 2022
@pjbgf pjbgf added this to the GA milestone Oct 19, 2022
@stefanprodan
Copy link
Member

Can you please test this on AWS CodeCommit?

@pjbgf
Copy link
Member Author

pjbgf commented Oct 20, 2022

@stefanprodan works fine, in line with the tests done for fluxcd/go-git#4.

./bin/flux bootstrap git --url https://<ORG>.us-east-1.amazonaws.com/v1/repos/<REPO> --username "${git_username}" --password "${git_pass}" --token-auth
► cloning branch "main" from Git repository "https://<ORG>.us-east-1.amazonaws.com/v1/repos/<REPO>"
✔ cloned repository
► generating component manifests
✔ generated component manifests
✔ committed sync manifests to "main" ("b007392920c4aad8ca9068c9e81c4efe562815f3")
► pushing component manifests to "https://<ORG>.us-east-1.amazonaws.com/v1/repos/<REPO>"
► installing components in "flux-system" namespace
✔ installed components
✔ reconciled components
► determining if source secret "flux-system/flux-system" exists
► generating source secret
► applying source secret "flux-system/flux-system"
✔ reconciled source secret
► generating sync manifests
✔ generated sync manifests
✔ committed sync manifests to "main" ("ccb8000bae5e7f0b2a0d509a41b613571ccf1ac2")
► pushing sync manifests to "https://<ORG>.us-east-1.amazonaws.com/v1/repos/<REPO>"
► applying sync manifests
✔ reconciled sync configuration
◎ waiting for Kustomization "flux-system/flux-system" to be reconciled

@pjbgf
Copy link
Member Author

pjbgf commented Nov 10, 2022

Superseded by #3299.

@pjbgf pjbgf closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants