chore(integrations/registry): remove deprecated kustomize features #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem <67638547+Stringls@users.noreply.github.com>
Stringls
force-pushed
the
replace-deprecated-kustomize-features
branch
from
0f38193
to
e0dcd85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecated
kustomizefeatures as discussed here.varsfeature has not been removed asreplacementscannot replace a var$()with the value patched outside the_basefolder. I opened an issue inkustomizeGitHub repository - link. I am awaiting for a response.Also, besides removing deprecated
kustomizefeatures I also added missing files (e.g.kustomizeconfig.yamlto be able to usevarsreplacement inaws/patch Deployment to specify a name of the secret with AWS credentials, etc.) and edited incorrect files.I see the point why there were missing/incorrect files as on FluxCD website we suggest users to copy/paste the manifests and not to use those one stored in
flux2repository (perhaps we use these manifests somewhere else?). So it's fine if you'd like to revert the changes I made (adding new files).I only updated
registry-credentials-syncfolder as there are already many changed files so you may wish to separate PRs so it's more convenient for you to review the PR. Please let me know your thoughts around that.