Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (create|delete|export) source chart commands #4773

Merged
merged 1 commit into from May 9, 2024

Conversation

makkes
Copy link
Member

@makkes makkes commented May 9, 2024

The create source chart command supports all HelmChart.spec fields except .valuesFiles and ignoreMissingValuesFiles as these are assumingly rarely used fields and the CLI usually only supports commonly used ones.

closes #4760

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes 🏅

@stefanprodan stefanprodan added the area/helm Helm related issues and pull requests label May 9, 2024
The `create source chart` command supports all HelmChart.spec fields
except `.valuesFiles` and `ignoreMissingValuesFiles` as these are
assumingly rarely used fields and the CLI usually only supports
commonly used ones.

closes #4760

Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Max Jonas Werner <mail@makk.es>
@stefanprodan stefanprodan merged commit 54f33ec into main May 9, 2024
8 checks passed
@stefanprodan stefanprodan deleted the source-chart-cmds branch May 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commands for working with HelmChart v1 objects
2 participants