Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Kubernetes 1.28 as min required version #4781

Merged
merged 2 commits into from May 10, 2024
Merged

Set Kubernetes 1.28 as min required version #4781

merged 2 commits into from May 10, 2024

Conversation

stefanprodan
Copy link
Member

Changes:

  • Update the Kubernetes version check and drop EOL versions
  • Update kubectl to 1.30.0 in the flux-cli Dockerfile

Part of: #4712

@stefanprodan
Set Kubernetes 1.28 as min required version
d8e6199 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Update kubectl to 1.30.0 in flux-cli image
9ef9464 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the dependencies Pull requests that update a dependency label May 10, 2024
@stefanprodan stefanprodan mentioned this pull request May 10, 2024
Merged
souleb
souleb approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit 070fa0f into main May 10, 2024
9 checks passed
@stefanprodan stefanprodan deleted the drop-kubernetes-eol branch May 10, 2024 16:34
@cwrau
Copy link

cwrau commented May 15, 2024

Quick question, in the description you mentioned drop EOL versions, but you also dropped 1.27?

And in any case, shouldn't this be a breaking change?

@stefanprodan
Copy link
Member Author

We only support the last 3 minor versions of Kubernetes. Also 1.27 active support ended 2 weeks ago, see https://endoflife.date/kubernetes

@cwrau
Copy link

cwrau commented May 15, 2024

We only support the last 3 minor versions of Kubernetes.

I understand, but I would've expected a major release for such a change, I guess?

Also 1.27 active support ended 2 weeks ago, see endoflife.date/kubernetes

Huh, interesting, I just looked at https://kubernetes.io/releases/#release-v1-27 and it shows it to be not EOL for another ~1.5 months 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souleb souleb souleb approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanprodan @cwrau @souleb