Upgrade dependencies #218
Merged
Upgrade dependencies #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
May 3, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 58.80% 58.78% -0.03%
==========================================
Files 75 75
Lines 6178 6182 +4
==========================================
+ Hits 3633 3634 +1
- Misses 2002 2004 +2
- Partials 543 544 +1
☔ View full report in Codecov by Sentry. |
stefanprodan
approved these changes
May 3, 2023
makkes
force-pushed
the
bump-deps
branch
4 times, most recently
from
a4c2d03
to
f7bca8a
Compare
stefanprodan
reviewed
May 4, 2023
go-git 5.5.1 shipped a breaking change (go-git/go-git#623) that we need to take into account here in setting `AllowEmptyCommits: true` when initializing a bitbucket repository. Signed-off-by: Max Jonas Werner <mail@makk.es>
The tests are already triggered by the `pull-request` event (which is also emitted when the head branch of the PR is updated). For PRs created from branches of the ggp repo, having the `push` event for all branches in the workflow definition will trigger it twice. Therefore I changed it to only run on pushes to `main` now, following what we do in other repos. Signed-off-by: Max Jonas Werner <mail@makk.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-git 5.5.1 shipped a breaking change (go-git/go-git#623) that we need to take into account here in setting
AllowEmptyCommits: truewhen initializing a bitbucket repository.