This repository has been archived by the owner on May 23, 2023. It is now read-only.
add support for specifying custom proxy options #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add support for HTTP proxying to the HTTP client. Also, refactor the client fetching logic to allow support for custom clients for the `https` scheme. Earlier, any client installed for the `https` would be ignored if `ep.InsecureSkipTls` was true or if `ep.CaBundle` was non-empty. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
proxy-support
branch
from
36f0359
to
292d6c1
Compare
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
proxy-support
branch
from
292d6c1
to
bf2058b
Compare
|
Master compatibility is orthogonal, and fixed upstream via go-git#739. |
|
Closing this given fluxcd/pkg#562, which makes this repository obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying custom proxy options (
transport.ProxyOptions) alongside any remote operation. Earlier the only way to use a proxy was via an env var, which is restrictive when using this project as a package.Furthermore, the HTTP(s) client has been refactored to make sure that all transport level configurations do not affect the client itself. Earlier, any custom client installed for the
httpswould be ignored ifep.InsecureSkipTlswas true or ifep.CaBundlewas non-empty. Lastly, tests have been added for both SSH and HTTP clients alongside separate tests for env vars.