Fix DependsOn readiness check

Signed-off-by: Sean Eagan <seaneagan@microsoft.com>
fluxcd · Apr 18, 2024 · 806947c · 806947c
1 parent 5e760db
commit 806947c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/controller/helmrelease_controller.go b/internal/controller/helmrelease_controller.go
@@ -585,7 +585,7 @@ func (r *HelmReleaseReconciler) checkDependencies(ctx context.Context, obj *v2.H
 			return fmt.Errorf("unable to get '%s' dependency: %w", ref, err)
 		}
 
-		if dHr.Generation != dHr.Status.ObservedGeneration || !conditions.IsTrue(dHr, meta.ReadyCondition) {
+		if dHr.Generation != conditions.GetObservedGeneration(dHr, meta.ReadyCondition) || !conditions.IsTrue(dHr, meta.ReadyCondition) {
 			return fmt.Errorf("dependency '%s' is not ready", ref)
 		}
 	}