Add .spec.ignoreMissingValuesFiles to HelmChartTemplate API
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isometry
force-pushed
the
feature/ignore-missing-values-files
branch
2 times, most recently
from
897e927
to
370be06
Compare
isometry
force-pushed
the
feature/ignore-missing-values-files
branch
3 times, most recently
from
2d3bb0c
to
4d8e07b
Compare
isometry
changed the title
stefanprodan
reviewed
May 2, 2024
isometry
force-pushed
the
feature/ignore-missing-values-files
branch
from
4d8e07b
to
60cda7e
Compare
stefanprodan
changed the title
.spec.ignoreMissingValuesFiles to HelmChartTemplate API
stefanprodan
added
area/helm
|
@stefanprodan : will you create a new release tag on |
Signed-off-by: Robin Breathe <robin@isometry.net>
isometry
force-pushed
the
feature/ignore-missing-values-files
branch
from
60cda7e
to
bca7983
Compare
stefanprodan
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to ignore missing values files referenced in generated HelmCharts. Full backward compatibility is maintained.
I can't see any meaningful surface to test, as this is simply exposing underlying functionality from the
source-controllerAPI.Depends upon fluxcd/source-controller#1447