PostRenderersDigest observation improvements #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
improve-postrenderer-tracking
branch
from
7e2d085
to
c906e99
Compare
darkowlzz
commented
May 8, 2024
Comment on lines
-53
to
-60
| Patch: `|- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: test | ||
| spec: | ||
| replicas: 2 | ||
| `, |
There was a problem hiding this comment.
This was causing patch parsing failure when processed by atomic reconciler, due to |- and also due to the indentations. Removing the indentation resolved the parsing failure.
darkowlzz
force-pushed
the
improve-postrenderer-tracking
branch
from
c906e99
to
cd9e522
Compare
Move the post renderers digest set/update code from summarize() to atomic release reconciler in order to update the observation only at the end of a successful reconciliation. summarize() is for summarizing the status conditions and is also called by all the other action sub-reconcilers, which can update the post renderers digest observation too early. Updating the observed post renderers digest at the very end of a reconciliation introduces an issue where a digest mismatch in DetermineReleaseState() could result in the release to get stuck in a loop as even after running an upgrade due to post renderers value, the new observation isn't reflected immediately in the middle of atomic reconciliation. This can be solved by checking post renderers digest value only for new configurations where the object generation and the ready status condition observed generations don't match, in other words when the generation of a configuration has not be processed. This assumes that an upgrade due to any other reason also takes into account the post renderers value and need not be checked separately for the same config generation. Signed-off-by: Sunny <github@darkowlzz.space>
darkowlzz
force-pushed
the
improve-postrenderer-tracking
branch
from
cd9e522
to
63f7a76
Compare
|
I have added some more test scenarios involving post renderers in atomic release reconciler. Did more manual testing observing the behavior, everything seems as before and correct. |
stefanprodan
approved these changes
May 9, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minor improvement to the implementation of the observing the post renderers digest in #965 by moving the observation set/update code from
summarize()to atomic release reconciliation.summarize()is for summarizing the status conditions only and it is called by all the action sub-reconcilers. In addition, the post renderers digest value check is performed only for unprocessed new configuration. This is needed to prevent the atomic reconciliation from getting stuck in a loop when there are multiple upgrades, for example due to a config difference and a digest mismatch, and since the digest gets updated at the very end of a successful reconciliation, the release can get stuck. This make sure that the digest is checked only for unprocessed generation of the object. This behavior is only associated with the changes introduced here. Previously, the observation got updated early within thesummarize()which got around such issue.Also, adds more tests for various scenarios involving post renderers.