Block the creation of empty commits #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In specific cases, the update mechanism may lead to no files being changed. The changes short-circuit the process to exit early when 0 files have been modified. go-git has been changed to return an error when an empty commit is detected, which is used as a last resort. When the push branch is different than the clone branch, the controller will now download all branch references from the Git server, in order to enable a single fetch operation. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
aryan9600
reviewed
Dec 20, 2022
Comment on lines
+385
to
+387
| } else { | ||
| err = extgogit.ErrEmptyCommit | ||
| } |
There was a problem hiding this comment.
why are we creating an error here?
There was a problem hiding this comment.
This is to be able to reuse the existing logic for handling empty commits.
Given that this controller will be refactored as part of the GA process, I found this was the easiest way to resolve the problem without duplicating code.
hiddeco
approved these changes
Dec 20, 2022
stefanprodan
approved these changes
Dec 20, 2022
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specific cases, the update mechanism may lead to no files being changed. The changes short-circuit the process to exit early when 0 files have been modified.
go-git has been changed to return an error when an empty commit is detected, which is used as a last resort.
When the push branch is different than the clone branch, the controller will now download all branch references from the Git server, in order to enable a single fetch operation.
Fixes #466.